convert circleci workflows to github actions #42931

robandpdx · 2024-02-08T19:03:45Z

Summary:

This pull request converts the CircleCI workflows to GitHub actions workflows.

The github actions workflow is meant to mimic this circleci workflow.

Errors

test_ios_rntester jobs fails with errors.

build_npm_package job fails with an error indicating that the artifacts are not found. We may need to use upload-artifact and download-artifact rather than cache for these files.

test-windows job fails with unit test errors. See the log for details.

Questions

build_android and build_npm_package jobs take a parameter release_type. When and how does this get passed in?

Test Plan:

These workflows were tested in my fork. Here are the latest workflow runs:
test-all
test-js

https://fburl.com/workplace/f6mz6tmw

github-actions · 2024-02-08T19:04:45Z

	Fails
🚫	📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Generated by 🚫 dangerJS against a245a85

analysis-bot · 2024-02-08T19:33:38Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,012,519	-114,569
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,371,039	-122,787
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: fb42a55
Branch: main

NickGerleman · 2024-02-09T21:23:31Z

Very exciting 🙂.

@cortinico and @cipolleschi will be the experts on the existing setup, but I also took a quick look, and noticed a couple quick things:

The path-based workflow selection is a lot cleaner than the previous job selection script, and takes a workflow out of the critical path for all other workflows. I don't think the logic is exactly the same though. @cipolleschi wrote this and would be able to review and give feedback.
The test_ios_rntester jobs seem to be failing because of too old XCode version. We previously had a matrix where most jobs ran using XCode 15.0.1, with a couple running on 14.3 to test compat with slightly older versions. IIRC the macos-12 hosted runner has both installed, but defaulted to 14.2, so we can just xcode-select or use a preexisting action to do that. That upper-bound should actually probably now be XCode 15.1, but IIRC that had some trouble with CircleCI setup. Also a reminder to @cipolleschi wrt lower bound, since I know that came up recently (14.3 requirement should be in changelog as breaking change, if we don't want to bump to 15 min required for 0.74)
The build-android job, which doesn't use much cache except for tools already installed in the Docker container, seems to run about half the speed of the previous CircleCI job. Wondering if some of these should maybe be on larger runners.

NickGerleman · 2024-02-09T21:36:08Z

.github/workflows/test-all.yml

+            packages/react-native-codegen/lib
+          enableCrossOsArchive: true
+  test_android:
+    runs-on: ubuntu-latest


Suggested change

runs-on: ubuntu-latest

runs-on: 8-core-ubuntu

NickGerleman · 2024-02-09T21:36:54Z

.github/workflows/test-all.yml

+          mkdir -p "$DEST_DIR"
+          mv "hermes.framework.dSYM" "$DEST_DIR"
+  test_ios_rntester_ruby_3_2_0:
+    runs-on: macos-12


Suggested change

runs-on: macos-12

runs-on: macos-12-large

robandpdx · 2024-02-26T20:46:54Z

@cortinico and @cipolleschi, I have updated this PR to only include the jobs that are succeeding in my fork. Please merge this as we discussed. I'll follow up with other PRs as I get more jobs working. Thanks again for the help!

Here is the latest build of these changes in my branch.

cipolleschi · 2024-02-28T11:56:40Z

/rebase - this command should automatically rebase this PR on top of main

cortinico · 2024-03-01T02:30:40Z

/rebase

robandpdx · 2024-03-05T15:11:59Z

@cortinico @cipolleschi I have rebased my branch today. Here is the latest workflow run in my fork.

If you approve this workflow run, you should see the same results.

cortinico · 2024-03-05T16:08:17Z

If you approve this workflow run, you should see the same results.

So CircleCI jobs are currently red as we bumped packages on main to 0.75.0-main. @huntie are you looking into it?

huntie · 2024-03-06T15:18:16Z

@cortinico Fixed after both of:

robandpdx · 2024-03-07T00:50:00Z

@cortinico @cipolleschi Here is the latest workflow run from my fork. All green now. It would be great to get this merged soon.

cortinico · 2024-03-07T12:08:16Z

Here is the latest workflow run from my fork. All jobs should be green now.

Amazing work @robandpdx !
I've noticed that the test_android_template* and test_ios_template* jobs are still missing, right?

How do we want to split this work to start merging it? Should we do the Android first?

huntie

Just spotting a few nits.

.github/actions/cache_setup/action.yml

.github/actions/check_if_apple_artifacts_are_there/action.yml

.github/workflows/test-all.yml

rename step to be more concise Co-authored-by: Alex Hunt <[email protected]>

rename step Co-authored-by: Alex Hunt <[email protected]>

robandpdx · 2024-03-07T22:51:24Z

@cortinico The test_android_template* and test_ios_template* jobs are in progress and I'll follow up with another PR to add them. These jobs are dependent upon the build_npm_package job (at least that how it's configured in circleci), which I don't have working currently. Any help with the errors there is appreciated.

cortinico · 2024-03-08T11:04:59Z

@cortinico The test_android_template* and test_ios_template* jobs are in progress and I'll follow up with another PR to add them. These jobs are dependent upon the build_npm_package job (at least that how it's configured in circleci), which I don't have working currently. Any help with the errors there is appreciated.

Sure so a couple of pointers:

That's the first time I see this error, but apparently Gradle is failing to produce the .aar for React Native Android that needs to be consumed by the users.
I would first check if this is working fine:

https://github.com/robandpdx-org/react-native/blob/39c5c057fd7656009e2250f223c66ceeabf5e178/.github/workflows/test-all.yml#L790-L794

As the error message contains x86:

Could not add file '/__w/react-native/react-native/packages/react-native/ReactAndroid/build/intermediates/prefab_package/release/prefab/modules/react_render_uimanager/libs/android.x86/libreact_render_uimanager.a' to ZIP '/__w/react-native/react-native/packages/react-native/ReactAndroid/build/outputs/aar/ReactAndroid-release.aar'.

which is suspicious. For dry-run we produce only arm64-v8a.

I would go here:
https://github.com/robandpdx-org/react-native/blob/cd486bcfecb58c715d016b4d748179398990815b/scripts/releases/utils/release-utils.js#L26

and do this:

- if (exec('./gradlew publishAllToMavenTempLocal').code) {
+ if (exec('./gradlew publishAllToMavenTempLocal --info --stacktrace').code) {

to add more logging. This can provide a bit more insights on why the job is failing at the moment.

robandpdx · 2024-03-11T17:13:10Z

@cortinico I think it's best if I hand off this work to you or someone else who has the expertise to make it work.

cortinico · 2024-03-12T12:31:18Z

@cortinico I think it's best if I hand off this work to you or someone else who has the expertise to make it work.

Can we do the following:

Can you give me push rights to your fork so I can experiment a bit?
Could you start sending over smaller PRs for everything that is green so far? The smaller you can make them the better so I can distribute it for review to other colleagues.

robandpdx · 2024-03-13T21:23:43Z

@cortinico I have given you write permission to my fork.

In order to deliver small PRs, I would need a tool that can do stacked diffs across forks. I'm not aware of any such tool that supports stacked diffs across forks. The best I can do is get everything in this PR green.

This reverts commit f6c240e.

robandpdx · 2024-03-26T03:51:39Z

@cortinico I have opened this PR with only the android build and test.

react-native-bot · 2024-09-22T05:00:57Z

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot · 2024-09-22T05:00:59Z

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

cortinico · 2024-09-23T08:12:16Z

Close as we already merged this in main

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 8, 2024

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Feb 8, 2024

NickGerleman reviewed Feb 9, 2024

View reviewed changes

mattbfb mentioned this pull request Mar 6, 2024

convert circleci workflows to github actions facebook/hermes#1301

Closed

Convert circleci workflows to github actions.

16b4cdb

huntie reviewed Mar 7, 2024

View reviewed changes

robandpdx and others added 3 commits March 7, 2024 17:39

Update .github/actions/check_if_apple_artifacts_are_there/action.yml

d51db4b

rename step to be more concise Co-authored-by: Alex Hunt <[email protected]>

Update .github/workflows/test-all.yml

923ee6b

rename step Co-authored-by: Alex Hunt <[email protected]>

newlines via editorconfig, fix typo

967160d

cortinico added 2 commits March 15, 2024 12:37

Add more logging

f6c240e

Revert "Add more logging"

a245a85

This reverts commit f6c240e.

react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 22, 2024

cortinico closed this Sep 23, 2024

convert circleci workflows to github actions #42931

convert circleci workflows to github actions #42931

Uh oh!

Conversation

robandpdx commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Errors

Questions

Test Plan:

Uh oh!

github-actions bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NickGerleman commented Feb 9, 2024

Uh oh!

NickGerleman Feb 9, 2024

Choose a reason for hiding this comment

Uh oh!

NickGerleman Feb 9, 2024

Choose a reason for hiding this comment

Uh oh!

robandpdx commented Feb 26, 2024

Uh oh!

cipolleschi commented Feb 28, 2024

Uh oh!

cortinico commented Mar 1, 2024

Uh oh!

robandpdx commented Mar 5, 2024

Uh oh!

cortinico commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huntie commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robandpdx commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortinico commented Mar 7, 2024

Uh oh!

huntie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robandpdx commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortinico commented Mar 8, 2024

Uh oh!

robandpdx commented Mar 11, 2024

Uh oh!

cortinico commented Mar 12, 2024

Uh oh!

robandpdx commented Mar 13, 2024

Uh oh!

robandpdx commented Mar 26, 2024

Uh oh!

react-native-bot commented Sep 22, 2024

Uh oh!

react-native-bot commented Sep 22, 2024

Uh oh!

cortinico commented Sep 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

robandpdx commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

analysis-bot commented Feb 8, 2024 •

edited

Loading

cortinico commented Mar 5, 2024 •

edited

Loading

huntie commented Mar 6, 2024 •

edited

Loading

robandpdx commented Mar 7, 2024 •

edited

Loading

robandpdx commented Mar 7, 2024 •

edited

Loading