Codegen 118: add throwIfBubblingTypeisNull in error-utils and use it in events #37191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 76a42c2 |
Contributor
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
May 2, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Great work, thank you for taking the time to address this. Also, thanks for aligning the implementation between Flow and Typescript, adding the nullable return type in build event schema.
Contributor
|
@dmytrorykun merged this pull request in 8494707. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…in events (facebook#37191) Summary: part of codegen Issue facebook#34872 > Extract the code that throws if argumentProps are null in a throwIfBubblingTypeisNull function in the error-utils.js file. Use it in the [flow/components/events.js](https://github.com/facebook/react-native/blob/e133100721939108b0f28dfa9f60ac627c804018/packages/react-native-codegen/src/parsers/flow/components/events.js#L244-L246) and in the [typescript/components/event.js](https://github.com/facebook/react-native/blob/e133100721939108b0f28dfa9f60ac627c804018/packages/react-native-codegen/src/parsers/typescript/components/events.js#L232-L233) files ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal][Changed]: Add throwIfBubblingTypeisNull in error-utils and use it in events Pull Request resolved: facebook#37191 Test Plan: `yarn jest react-native-codegen` Reviewed By: cipolleschi Differential Revision: D45478073 Pulled By: dmytrorykun fbshipit-source-id: f70ce3f32d93170cafcea9c8b8c2ba06e760fa37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
part of codegen Issue #34872
Changelog:
[Internal][Changed]: Add throwIfBubblingTypeisNull in error-utils and use it in events
Test Plan:
yarn jest react-native-codegen