Codegen 118: add throwIfBubblingTypeisNull in error-utils and use it in events (#37191)

Summary:
part of codegen Issue #34872

> Extract the code that throws if argumentProps are null in a throwIfBubblingTypeisNull function in the error-utils.js file. Use it in the [flow/components/events.js](https://github.com/facebook/react-native/blob/e133100721939108b0f28dfa9f60ac627c804018/packages/react-native-codegen/src/parsers/flow/components/events.js#L244-L246) and in the [typescript/components/event.js](https://github.com/facebook/react-native/blob/e133100721939108b0f28dfa9f60ac627c804018/packages/react-native-codegen/src/parsers/typescript/components/events.js#L232-L233) files

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal][Changed]: Add throwIfBubblingTypeisNull in error-utils and use it in events

Pull Request resolved: #37191

Test Plan: `yarn jest react-native-codegen`

Reviewed By: cipolleschi

Differential Revision: D45478073

Pulled By: dmytrorykun

fbshipit-source-id: f70ce3f32d93170cafcea9c8b8c2ba06e760fa37

Author: tarunrajput

packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js

@@ -34,6 +34,7 @@ const {
   throwIfPartialWithMoreParameter,
   throwIfMoreThanOneCodegenNativecommands,
   throwIfEventHasNoName,
+  throwIfBubblingTypeIsNull,
 } = require('../error-utils');
 const {
   UnsupportedModulePropertyParserError,
@@ -950,3 +951,25 @@ describe('throwIfEventHasNoName', () => {
     }).not.toThrow();
   });
 });
+
+describe('throwIfBubblingTypeIsNull', () => {
+  it('throw an error if unable to determine event bubbling type', () => {
+    const bubblingType = null;
+    const eventName = 'Event';
+
+    expect(() => {
+      throwIfBubblingTypeIsNull(bubblingType, eventName);
+    }).toThrowError(
+      `Unable to determine event bubbling type for "${eventName}"`,
+    );
+  });
+
+  it('does not throw an error if able to determine event bubbling type', () => {
+    const bubblingType = 'direct';
+    const eventName = 'Event';
+
+    expect(() => {
+      throwIfBubblingTypeIsNull(bubblingType, eventName);
+    }).not.toThrow();
+  });
+});

packages/react-native-codegen/src/parsers/error-utils.js

@@ -319,6 +319,17 @@ function throwIfEventHasNoName(typeAnnotation: $FlowFixMe, parser: Parser) {
   }
 }
 
+function throwIfBubblingTypeIsNull(
+  bubblingType: ?('direct' | 'bubble'),
+  eventName: string,
+) {
+  if (!bubblingType) {
+    throw new Error(
+      `Unable to determine event bubbling type for "${eventName}"`,
+    );
+  }
+}
+
 module.exports = {
   throwIfModuleInterfaceIsMisnamed,
   throwIfUnsupportedFunctionReturnTypeAnnotationParserError,
@@ -340,4 +351,5 @@ module.exports = {
   throwIfConfigNotfound,
   throwIfMoreThanOneConfig,
   throwIfEventHasNoName,
+  throwIfBubblingTypeIsNull,
 };

packages/react-native-codegen/src/parsers/flow/components/events.js

@@ -16,7 +16,10 @@ import type {
   EventTypeAnnotation,
 } from '../../../CodegenSchema.js';
 import type {Parser} from '../../parser';
-const {throwIfEventHasNoName} = require('../../error-utils');
+const {
+  throwIfEventHasNoName,
+  throwIfBubblingTypeIsNull,
+} = require('../../error-utils');
 
 function getPropertyType(
   /* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
@@ -245,9 +248,7 @@ function buildEventSchema(
     throw new Error(`Unable to determine event arguments for "${name}"`);
   }
 
-  if (bubblingType === null) {
-    throw new Error(`Unable to determine event arguments for "${name}"`);
-  }
+  throwIfBubblingTypeIsNull(bubblingType, name);
 }
 
 // $FlowFixMe[unclear-type] there's no flowtype for ASTs

packages/react-native-codegen/src/parsers/typescript/components/events.js

@@ -19,7 +19,10 @@ import type {TypeDeclarationMap} from '../../utils';
 import type {Parser} from '../../parser';
 const {flattenProperties} = require('./componentsUtils');
 const {parseTopLevelType} = require('../parseTopLevelType');
-const {throwIfEventHasNoName} = require('../../error-utils');
+const {
+  throwIfEventHasNoName,
+  throwIfBubblingTypeIsNull,
+} = require('../../error-utils');
 
 function getPropertyType(
   /* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
@@ -219,7 +222,7 @@ function buildEventSchema(
   types: TypeDeclarationMap,
   property: EventTypeAST,
   parser: Parser,
-): EventTypeShape {
+): ?EventTypeShape {
   // unpack WithDefault, (T) or T|U
   const topLevelType = parseTopLevelType(
     property.typeAnnotation.typeAnnotation,
@@ -235,7 +238,7 @@ function buildEventSchema(
   if (!argumentProps) {
     throw new Error(`Unable to determine event arguments for "${name}"`);
   } else if (!bubblingType) {
-    throw new Error(`Unable to determine event bubbling type for "${name}"`);
+    throwIfBubblingTypeIsNull(bubblingType, name);
   } else {
     if (paperTopLevelNameDeprecated != null) {
       return {
@@ -267,9 +270,9 @@ function getEvents(
   types: TypeDeclarationMap,
   parser: Parser,
 ): $ReadOnlyArray<EventTypeShape> {
-  return eventTypeAST.map(property =>
-    buildEventSchema(types, property, parser),
-  );
+  return eventTypeAST
+    .map(property => buildEventSchema(types, property, parser))
+    .filter(Boolean);
 }
 
 module.exports = {