Make CLI executable configurable #13264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to #13248 for iOS
facebook-github-bot
added
CLA Signed
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
Contributor
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 3, 2017
Summary: Follow up to #13248 for iOS. This pull request allows changing the default path to `cli` when running from Xcode environment. That is especially useful when debugging from a different location or... running `Haul`. Set `export CLI_PATH=./node_modules/react-native/local-cli/cli.js` and run. Should use new path provided. Closes #13264 Differential Revision: D4819059 Pulled By: ericvicenti fbshipit-source-id: 4a6241823c0bc8f1fa16869bc872bdbe04df510f
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: Follow up to facebook#13248 for iOS. This pull request allows changing the default path to `cli` when running from Xcode environment. That is especially useful when debugging from a different location or... running `Haul`. Set `export CLI_PATH=./node_modules/react-native/local-cli/cli.js` and run. Should use new path provided. Closes facebook#13264 Differential Revision: D4819059 Pulled By: ericvicenti fbshipit-source-id: 4a6241823c0bc8f1fa16869bc872bdbe04df510f
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 25, 2018
Summary: @public This sync includes the following changes: - **[bc1ea9cd9](facebook/react@bc1ea9cd9)**: Handle errors thrown in gDSFP of a module-style context provider (#13269) //<Andrew Clark>// - **[0154a79fe](facebook/react@0154a79fe)**: Remove 'warning' module from the JS scheduler (#13264) //<Flarnie Marchan>// - **[dbd16c8a9](facebook/react@dbd16c8a9)**: Add flow directive to findDOMNode shim (#13265) //<Brian Vaughn>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions ca0941f...bc1ea9c Reviewed By: bvaughn Differential Revision: D9005608 fbshipit-source-id: c293add468badc5323179fda9341912710d4e840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #13248 for iOS.
Motivation (required)
This pull request allows changing the default path to
cliwhen running from Xcode environment. That is especially useful when debugging from a different location or... runningHaul.Test Plan (required)
Set
export CLI_PATH=./node_modules/react-native/local-cli/cli.jsand run. Should use new path provided.