Add iOS build phase #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
reviewed
Apr 3, 2017
src/commands/init.js
Outdated
| { | ||
| type: 'input', | ||
| name: 'entry', | ||
| message: 'Enter the name of the .xcodeproj file', |
Member
There was a problem hiding this comment.
Isn't this the path and not name?
satya164
requested changes
Apr 3, 2017
src/commands/init.js
Outdated
| let project = fs.readFileSync(path.join(entry, 'project.pbxproj')).toString(); | ||
|
|
||
| // Are we already integrated? | ||
| if (project.includes('AD0CE2C91E925489006FC317')) { |
src/commands/init.js
Outdated
| entry = path.resolve(cwd, result.entry); | ||
| } | ||
|
|
||
| const progress = ora('Adding haul to your native build pipeline'); |
Member
There was a problem hiding this comment.
Adding haul to your XCode build scripts
Though I feel like we should ask before this change. Looks rather invasive and I might just want to try before integrating.
src/commands/init.js
Outdated
|
|
||
| // Are we already integrated? | ||
| if (project.includes('AD0CE2C91E925489006FC317')) { | ||
| progress.info('Haul is already part of your build pipeline'); |
Member
There was a problem hiding this comment.
build pipeline sounds very serious, maybe build scripts is better
src/commands/init.js
Outdated
| progress.succeed('Added haul to your native build pipeline'); | ||
| } else { | ||
| progress.fail( | ||
| 'Failed to add Haul to your build pipeline. See docs for manual instructions.', |
Member
There was a problem hiding this comment.
nit: Mention XCode
Link to docs?
src/commands/init.js
Outdated
|
|
||
| if (sectionsCount > 0) { | ||
| fs.writeFileSync(path.join(entry, 'project.pbxproj'), project); | ||
| progress.succeed('Added haul to your native build pipeline'); |
satya164
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #87
As of now, the only valid approach for integrating Haul with existing React Native applications is to define a script phase that runs every time we build our project and overwrites
packager.sh(used to automatically start packager on run) andreact-native-xcode.sh(used to bundle your app).Problem with setting env variable
CLI_PATHis that some scripts are defined inReact.xcodeproj. That means scripts defined there will not receive env variables set by parent project.Thanks to regular expressions, this is rather easy.