Changed tracepoint info section to inherit section group #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s which contains traced fn
Contributor
|
This pull request has been merged in 3f3aa50. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 11, 2024
Summary: Originally submitted by github user aliher1911 https://github.com/aliher1911 in: https://github.com/aliher1911. However, the files were moved around and the importer cannot import this PR. Original description: > When section group is inherited from the function where tracepoint is defined, tracepoint definition could be discarded by linker together with function correctly. Otherwise tracepoint would reference discarded section and cause linker to fail as in facebook/folly#1395. Closes: facebook/folly#1396. Fixes: facebook/folly#1395. Fixes: facebook/fbthrift#384. Reviewed By: Orvid Differential Revision: D62073054 fbshipit-source-id: d75de3f3c37d3110ae5bc88cd0b6c3de5ebe331f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When section group is inherited from the function where tracepoint is defined, tracepoint definition could be discarded by linker together with function correctly. Otherwise tracepoint would reference discarded section and cause linker to fail as in #1395