Skip to content

Commit 1c90ba6

Browse files
yfeldblumfacebook-github-bot
authored andcommitted
let tracepoint info section inherit section group
Summary: Originally submitted by github user aliher1911 https://github.com/aliher1911 in: https://github.com/aliher1911. However, the files were moved around and the importer cannot import this PR. Original description: > When section group is inherited from the function where tracepoint is defined, tracepoint definition could be discarded by linker together with function correctly. Otherwise tracepoint would reference discarded section and cause linker to fail as in facebook/folly#1395. Closes: facebook/folly#1396. Fixes: facebook/folly#1395. Fixes: facebook/fbthrift#384. Reviewed By: Orvid Differential Revision: D62073054 fbshipit-source-id: d75de3f3c37d3110ae5bc88cd0b6c3de5ebe331f
1 parent 527cecc commit 1c90ba6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

third-party/folly/src/folly/tracing/StaticTracepoint-ELF.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
// Structure of note section for the probe.
132132
#define FOLLY_SDT_NOTE_CONTENT(provider, name, has_semaphore, arg_template) \
133133
FOLLY_SDT_ASM_1(990: FOLLY_SDT_NOP) \
134-
FOLLY_SDT_ASM_3( .pushsection .note.stapsdt,"","note") \
134+
FOLLY_SDT_ASM_3( .pushsection .note.stapsdt,"?","note") \
135135
FOLLY_SDT_ASM_1( .balign 4) \
136136
FOLLY_SDT_ASM_3( .4byte 992f-991f, 994f-993f, FOLLY_SDT_NOTE_TYPE) \
137137
FOLLY_SDT_ASM_1(991: .asciz FOLLY_SDT_NOTE_NAME) \

0 commit comments

Comments
 (0)