Merge workspace.toml into pyproject.toml #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
…y and consistency
…directories for type checking
jjmachan
reviewed
Aug 19, 2025
NirantK
force-pushed
the
remove-workspace
branch
from
9429dde to
89ccd93
Compare
… into remove-workspace
|
Related Documentation No published documentation to review for changes on this repository. How did I do? Any feedback? |
jjmachan
approved these changes
Aug 20, 2025
ahgraber
pushed a commit
to ahgraber/ragas
that referenced
this pull request
Aug 26, 2025
Moved pyproject.toml to where it belongs. This led to some surprises, which are also handled in this PR. 1. format docs and tests. They were excluded so far because of path issues as a silent error. 2. Similar issues with pyright. Important: I've excluded few things from pyright for now, fixed the rest. We should remove exclusions. I'll leave that for @anistark Fixes explodinggradients#2182
NirantK
added a commit
to NirantK/ragas-upgrades
that referenced
this pull request
Sep 1, 2025
Moved pyproject.toml to where it belongs. This led to some surprises, which are also handled in this PR. 1. format docs and tests. They were excluded so far because of path issues as a silent error. 2. Similar issues with pyright. Important: I've excluded few things from pyright for now, fixed the rest. We should remove exclusions. I'll leave that for @anistark Fixes explodinggradients#2182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved pyproject.toml to where it belongs. This led to some surprises, which are also handled in this PR.
Important: I've excluded few things from pyright for now, fixed the rest.
We should remove exclusions. I'll leave that for @anistark
Fixes #2182