new(tests): EIP-7702: Updates for Devnet-3 #733

marioevz · 2024-08-07T22:00:12Z

🗒️ Description

Introduces new tests and changes according to the latest EIP-7702 spec.

Requires #762

🔗 Related Issues

Fixes #703

✅ Checklist

All: Set appropriate labels for the changes.
All: Considered squashing commits to improve commit history.
All: Added an entry to CHANGELOG.md.
All: Considered updating the online docs in the ./docs/ directory.
Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

tests/prague/eip7702_set_code_tx/test_set_code_txs.py

…nd_eoa`

…end_with_defaults (#758)

danceratopz

@marioevz there's a few minor things below - I'm still grappling with tests. I wanted to get visibility of the parameter combinations (for test_gas_costs, in particular) and hacked something together quickly to visualize and sort the values by parameter. Here's the result, I hope it can help you to notice any missing coverage/combinations. If you think this is useful I can make a PR for the pytest plugin 😆 that generated this.

Open the root folder in your browser 🙂
7702-parametrized-cases-html.tar.gz

This could be added to the doc flow to help document test cases.

tests/prague/eip7702_set_code_tx/spec.py

tests/prague/eip7702_set_code_tx/test_gas.py

tests/prague/eip7702_set_code_tx/test_set_code_txs.py

Co-authored-by: danceratopz <[email protected]>

marioevz · 2024-09-03T16:55:11Z

@marioevz there's a few minor things below - I'm still grappling with tests. I wanted to get visibility of the parameter combinations (for test_gas_costs, in particular) and hacked something together quickly to visualize and sort the values by parameter. Here's the result, I hope it can help you to notice any missing coverage/combinations. If you think this is useful I can make a PR for the pytest plugin 😆 that generated this.

Open the root folder in your browser 🙂 7702-parametrized-cases-html.tar.gz

This could be added to the doc flow to help document test cases.

This is awesome, it looks really nice this way, do you think we could automatically generate this for the docs?

spencer-tb

LGTM!

Happy for us to merge this if we wanted to create a new release. I plan to review this again properly but if there is anything else we can always add subsequent PRs.

* feat(base_types): Add `keccak256` to `Bytes` * fix(fw): EIP-7702 types update * fix(types): nonce list logic removal * feat(types): Calculate signer if v,r,s parameters are in the Auth Tuple * feat(types/filler): Allow delegation on `pre.fund_eoa` * feat(types): Add `Literal["Self"]` as option to delegation in `pre.fund_eoa` * fix(plugins/filler): fix delegation check * fix(plugins/filler): delegation designation in case of `None` * feat(evm_transition_tool): `SetCodeDelegation` to transaction receipt * new(tests): EIP-7702 spec update * new(tests): EIP-7702 add all invalid auth tuples test * new(tests): EIP-7702 add multiple valid, self-sponsored test * fix(tests): EIP-7702 enable skipped tests * refactor(tests): EIP-7702 rename folder and files * new(tests): EIP-7702, some failing tests * fix(tests): EIP-7702 gas test * fix(tests): EIP-7702 move gas tests * new(tests): EIP-7702 intrinsic gas tests * fix(fixtures): tests * fix(tests): import * simplify parametrization * refactor(tests): EIP-7702 gas tests * new(tests): EIP-7702 more gas tests * new(tests): EIP-7702 parametrize and add new tests * fix(tests): EIP-7702 add check * feat(exceptions): Add two type-4 tx exceptions * new(tests): EIP-7702 tests * fix(tests): Update tests according to spec changes ethereum/EIPs#8795 * fix(tests): EIP-7702, use `named_parametrize` * fix(tests): EIP-7702 test not following spec * fix(tests): EIP-7702 test authorization list nonce/gas * fix(tests): EIP-7702 fix test_ext_code_on_chain_delegating_set_code * fix(tests): EIP-7702 fix test_set_code_all_invalid_authorization_tuples * fix(tests): EIP-7702 fix test_set_code_invalid_authorization_tuple * fix(tests): EIP-7702 system-contract tests * fix(tests): EIP-7702 tox * refactor(tests): EIP-7702 `parametrize_with_defaults` rename * fix(tests): EIP-7702 test_ext_code_on_set_code * fix(tests): EIP-7702 test_ext_code_on_set_code * fix(tests): EIP-7702 test_set_code_to_sstore * fix(tests): EIP-7702, add delegation designation to all expected outputs * fix(tests): EIP-7702, add delegation designation * new(tests): EIP-7702, add eoa tx after set code tests * refactor(tests): EIP-7702 update for parametrize_with_defaults -> extend_with_defaults (ethereum#758) * fix(tests): Marker * fix(tests): EIP-7702: pre-existing delegation gas tests * fix(tests): EIP-7702: fix warm costs expectations * fix(tests): EIP-7702 re-authorization tests * fix(tests): EIP-7702 warm account logic revamp * fix(tests): EIP-7702 test fixes * feat(tests): EIP-7702 add self-delegation warm cost test * fix(test): EIP-7702, test_call_into_self_delegating_set_code * fix(tests): EIP-7702 use kwargs on `with_all` markers * docs: Changelog * fix(tests): EIP-7702 return code expectations * fix(tests): EIP-7702 invalid tx on invalid signatures * Apply suggestions from code review Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]>

pdobacz added a commit to ipsilon/evmone that referenced this pull request Aug 8, 2024

Update statetest_loader to match ethereum/execution-spec-tests#733

e5fdb2f

marioevz force-pushed the eip-7702-devnet-3 branch 3 times, most recently from 70ab500 to f374fa0 Compare August 13, 2024 23:42

marioevz marked this pull request as ready for review August 13, 2024 23:43

marioevz added the type:test Type: Add/refactor fw unit tests; no fw or el client test case changes label Aug 13, 2024

marioevz marked this pull request as draft August 13, 2024 23:43

marioevz force-pushed the eip-7702-devnet-3 branch from f374fa0 to 80890f3 Compare August 14, 2024 17:26

jochem-brouwer mentioned this pull request Aug 17, 2024

Implement T8N support (tracking issue) ethereumjs/ethereumjs-monorepo#3602

Closed

marioevz force-pushed the eip-7702-devnet-3 branch from 7933670 to 8dd0a5e Compare August 19, 2024 19:23

jochem-brouwer reviewed Aug 20, 2024

View reviewed changes

tests/prague/eip7702_set_code_tx/test_set_code_txs.py Show resolved Hide resolved

gumb0 pushed a commit to ipsilon/evmone that referenced this pull request Aug 21, 2024

Update statetest_loader to match ethereum/execution-spec-tests#733

aaa5a44

marioevz force-pushed the eip-7702-devnet-3 branch from c1afe74 to 1e40a62 Compare August 22, 2024 22:20

gumb0 reviewed Aug 23, 2024

View reviewed changes

tests/prague/eip7702_set_code_tx/test_set_code_txs.py Show resolved Hide resolved

gumb0 reviewed Aug 23, 2024

View reviewed changes

tests/prague/eip7702_set_code_tx/test_set_code_txs.py Outdated Show resolved Hide resolved

marioevz force-pushed the eip-7702-devnet-3 branch 2 times, most recently from 396d51c to 136083a Compare August 27, 2024 19:35

marioevz marked this pull request as ready for review August 27, 2024 19:52

gumb0 pushed a commit to ipsilon/evmone that referenced this pull request Aug 28, 2024

Update statetest_loader to match ethereum/execution-spec-tests#733

84f7e1f

gumb0 pushed a commit to ipsilon/evmone that referenced this pull request Aug 29, 2024

Update statetest_loader to match ethereum/execution-spec-tests#733

0a87040

marioevz added 10 commits August 30, 2024 18:14

feat(base_types): Add keccak256 to Bytes

fd12981

fix(fw): EIP-7702 types update

b05e545

fix(types): nonce list logic removal

f3fe06e

feat(types): Calculate signer if v,r,s parameters are in the Auth Tuple

d8748db

feat(types/filler): Allow delegation on pre.fund_eoa

e04c055

feat(types): Add Literal["Self"] as option to delegation in `pre.fu…

6aceae9

…nd_eoa`

fix(plugins/filler): fix delegation check

4e36074

fix(plugins/filler): delegation designation in case of None

ea64627

feat(evm_transition_tool): SetCodeDelegation to transaction receipt

2946057

new(tests): EIP-7702 spec update

53d1866

marioevz and others added 21 commits August 30, 2024 18:14

fix(tests): EIP-7702 tox

25b090f

refactor(tests): EIP-7702 parametrize_with_defaults rename

3039d08

fix(tests): EIP-7702 test_ext_code_on_set_code

f518215

fix(tests): EIP-7702 test_ext_code_on_set_code

4d9fa3d

fix(tests): EIP-7702 test_set_code_to_sstore

19e81ad

fix(tests): EIP-7702, add delegation designation to all expected outputs

bf545a9

fix(tests): EIP-7702, add delegation designation

86ef92d

new(tests): EIP-7702, add eoa tx after set code tests

6a6512d

refactor(tests): EIP-7702 update for parametrize_with_defaults -> ext…

3f11b1f

…end_with_defaults (#758)

fix(tests): Marker

7798a8e

fix(tests): EIP-7702: pre-existing delegation gas tests

008ee59

fix(tests): EIP-7702: fix warm costs expectations

80daaae

fix(tests): EIP-7702 re-authorization tests

e8798bf

fix(tests): EIP-7702 warm account logic revamp

435a82f

fix(tests): EIP-7702 test fixes

9125629

feat(tests): EIP-7702 add self-delegation warm cost test

bb93f7d

fix(test): EIP-7702, test_call_into_self_delegating_set_code

d31824f

fix(tests): EIP-7702 use kwargs on with_all markers

0369868

docs: Changelog

f576765

fix(tests): EIP-7702 return code expectations

d8cd1e5

fix(tests): EIP-7702 invalid tx on invalid signatures

16978ca

marioevz force-pushed the eip-7702-devnet-3 branch from e70d831 to 16978ca Compare August 30, 2024 19:03

danceratopz reviewed Sep 3, 2024

View reviewed changes

tests/prague/eip7702_set_code_tx/spec.py Outdated Show resolved Hide resolved

tests/prague/eip7702_set_code_tx/test_gas.py Outdated Show resolved Hide resolved

tests/prague/eip7702_set_code_tx/test_set_code_txs.py Outdated Show resolved Hide resolved

Apply suggestions from code review

266571f

Co-authored-by: danceratopz <[email protected]>

spencer-tb approved these changes Sep 5, 2024

View reviewed changes

marioevz merged commit 59379a8 into main Sep 5, 2024

marioevz deleted the eip-7702-devnet-3 branch September 5, 2024 20:21

marioevz mentioned this pull request Apr 14, 2025

Remaining 7702 Tests for Devnet-3 #703

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

new(tests): EIP-7702: Updates for Devnet-3 #733

new(tests): EIP-7702: Updates for Devnet-3 #733

Uh oh!

marioevz commented Aug 7, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danceratopz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz commented Sep 3, 2024

Uh oh!

spencer-tb left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

new(tests): EIP-7702: Updates for Devnet-3 #733

new(tests): EIP-7702: Updates for Devnet-3 #733

Uh oh!

Conversation

marioevz commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues

✅ Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz commented Sep 3, 2024

Uh oh!

spencer-tb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marioevz commented Aug 7, 2024 •

edited

Loading