Skip to content

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #20225

/assign ahrtr

@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jul 4, 2025

/ok-to-test

@ahrtr ahrtr changed the title [release-3.6] Add verification to verify the watch response have a bigger revision than minRev [release-3.6] Add verification to verify the watch response have a bigger revision than startRev Jul 4, 2025
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.37%. Comparing base (5897bc4) to head (ab13cb1).
Report is 2 commits behind head on release-3.6.

Files with missing lines Patch % Lines
server/storage/mvcc/watchable_store.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/watchable_store.go 93.75% <60.00%> (-0.86%) ⬇️

... and 29 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #20277      +/-   ##
===============================================
- Coverage        68.96%   68.37%   -0.60%     
===============================================
  Files              420      420              
  Lines            35655    35660       +5     
===============================================
- Hits             24589    24382     -207     
- Misses            9641     9843     +202     
- Partials          1425     1435      +10     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5897bc4...ab13cb1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr
Copy link
Member

ahrtr commented Jul 4, 2025

/test pull-etcd-integration-4-cpu-amd64

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fuweid fuweid merged commit 61dae25 into etcd-io:release-3.6 Jul 5, 2025
28 checks passed
@ivanvc ivanvc mentioned this pull request Jul 6, 2025
2 tasks
@ivanvc
Copy link
Member

ivanvc commented Jul 6, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot
Copy link
Author

@ivanvc: I cannot cherry-pick the present PR on top of its base branch (release-3.6).

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jul 6, 2025

Duh, wrong PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants