-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[release-3.6] Add verification to verify the watch response have a bigger revision than startRev #20277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.6] Add verification to verify the watch response have a bigger revision than startRev #20277
Conversation
…than minRev Signed-off-by: Benjamin Wang <[email protected]>
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 29 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #20277 +/- ##
===============================================
- Coverage 68.96% 68.37% -0.60%
===============================================
Files 420 420
Lines 35655 35660 +5
===============================================
- Hits 24589 24382 -207
- Misses 9641 9843 +202
- Partials 1425 1435 +10 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/test pull-etcd-integration-4-cpu-amd64 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.6 |
@ivanvc: I cannot cherry-pick the present PR on top of its base branch ( In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Duh, wrong PR 😅 |
This is an automated cherry-pick of #20225
/assign ahrtr