Skip to content

Drop non-functional Request.cookies property. #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Drop non-functional Request.cookies property. #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions httpx/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,7 @@ def __init__(
self.url = URL(url, params=params)
self.headers = Headers(headers)
if cookies:
self._cookies = Cookies(cookies)
self._cookies.set_cookie_header(self)
Cookies(cookies).set_cookie_header(self)

if stream is not None:
self.stream = stream
Expand Down Expand Up @@ -640,12 +639,6 @@ def prepare(self) -> None:
for item in reversed(auto_headers):
self.headers.raw.insert(0, item)

@property
def cookies(self) -> "Cookies":
if not hasattr(self, "_cookies"):
self._cookies = Cookies()
return self._cookies

def __repr__(self) -> str:
class_name = self.__class__.__name__
url = str(self.url)
Expand Down