Drop non-functional Request.cookies property.
#703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovelydinosaur
added
the
user-experience
florimondmanca
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this might look like an API breaking change on first sight, I think we could actually treat it as a borderline bugfix...
We're currently exposing a
.cookiesproperty onRequest, but we don't do anything with it.If a user builds a request instance explicitly, and sets items on
request.cookiesit won't have any effect.I'd potentially be okay with us having a
request.cookiesproperty at some point, tho it's not neccessarily a given that we ought to. Given that it doesn't currently have the behavior users would expect from it, I think it's reasonable just to drop it outright for now.