Skip to content

pr 230826 #231022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

pr 230826 #231022

wants to merge 4 commits into from

Conversation

wildemat
Copy link
Contributor

@wildemat wildemat commented Aug 7, 2025

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

TattdCodeMonkey and others added 4 commits August 6, 2025 13:47
@TattdCodeMonkey
search_homepage: add hook for ingestion cta experiment flag
27f39ef
@TattdCodeMonkey
search_homepage: add loading state
b9ba19d 
updated rendering to have a loading state while querying for the
onboarding redirect. This will ensure the body is not rendered if we are
going to redirect the user. This then should ensure we do not track loaded
telemetry events unless we actually render the home page body for the
user to view.
@TattdCodeMonkey
search: homepage ingestion variant view
96b8f40
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
cddf074 
…fix'
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@wildemat wildemat closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wildemat @elasticmachine @TattdCodeMonkey @kibanamachine