Skip to content

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Aug 5, 2025

Summary

Closes #230622

As part of https://github.com/elastic/observability-dev/issues/4757.
I'm currently investigating the status of Kibana's dependencies. I found out that some are no longer used, so this PR removes them.

Dependencies removed:

  • @aws-crypto/sha256-js
  • @aws-crypto/util
  • @formatjs/intl-pluralrules
  • @formatjs/intl-relativetimeformat
  • @langtrase/trace-attributes
  • ansi-regex
  • d3-shape
  • d3-time
  • re-resizable
  • @types/d3-shape
  • @types/d3-time

@rmyz rmyz self-assigned this Aug 5, 2025
@rmyz
Copy link
Contributor Author

rmyz commented Aug 5, 2025

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #96 / InfraOps App Metrics UI Home page with metrics present group nodes by custom field

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.5MB 6.5MB -1.0B

cc @rmyz

@rmyz rmyz changed the title chore: remove unused deps Remove unused deps Aug 6, 2025
@rmyz rmyz added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team dependency-reduction initiative to reduce the number of Kibana's third-party dependencies labels Aug 6, 2025
@rmyz rmyz marked this pull request as ready for review August 6, 2025 07:34
@rmyz rmyz requested a review from a team as a code owner August 6, 2025 07:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Comment on lines -27 to -28
"@npm//@formatjs/intl-pluralrules",
"@npm//@formatjs/intl-relativetimeformat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Became obsolete after #186519.

@rmyz rmyz merged commit 62fa2c7 into elastic:main Aug 6, 2025
24 checks passed
@rmyz rmyz deleted the 230622-remove-unused-deps branch August 6, 2025 11:35
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16775787506

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 6, 2025
(cherry picked from commit 62fa2c7)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18 Backport failed because of merge conflicts
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- chore(NA): upgrade typescript into v5.4.5 (#227746)
- [ska] relocate cypress & plugin functional tests (#228681)
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- chore(NA): upgrade typescript into v5.4.5 (#227746)
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 230630

Questions ?

Please refer to the Backport tool documentation

rmyz added a commit to rmyz/kibana that referenced this pull request Aug 6, 2025
(cherry picked from commit 62fa2c7)

# Conflicts:
#	package.json
#	yarn.lock
rmyz added a commit to rmyz/kibana that referenced this pull request Aug 6, 2025
(cherry picked from commit 62fa2c7)

# Conflicts:
#	yarn.lock
rmyz added a commit to rmyz/kibana that referenced this pull request Aug 6, 2025
(cherry picked from commit 62fa2c7)

# Conflicts:
#	package.json
#	yarn.lock
@rmyz
Copy link
Contributor Author

rmyz commented Aug 6, 2025

💚 All backports created successfully

Status Branch Result
9.0
8.19
8.18
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

rmyz added a commit to rmyz/kibana that referenced this pull request Aug 6, 2025
(cherry picked from commit 62fa2c7)

# Conflicts:
#	package.json
#	renovate.json
#	yarn.lock
rmyz added a commit to rmyz/kibana that referenced this pull request Aug 6, 2025
(cherry picked from commit 62fa2c7)
kibanamachine added a commit that referenced this pull request Aug 6, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [Remove unused deps
(#230630)](#230630)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-06T11:35:50Z","message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","Team:obs-ux-infra_services","v9.2.0","dependency-reduction"],"title":"Remove
unused
deps","number":230630,"url":"https://github.com/elastic/kibana/pull/230630","mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230630","number":230630,"mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
rmyz added a commit that referenced this pull request Aug 7, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Remove unused deps
(#230630)](#230630)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-06T11:35:50Z","message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","Team:obs-ux-infra_services","v9.2.0","dependency-reduction"],"title":"Remove
unused
deps","number":230630,"url":"https://github.com/elastic/kibana/pull/230630","mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230630","number":230630,"mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},{"url":"https://github.com/elastic/kibana/pull/230767","number":230767,"branch":"9.1","state":"OPEN"}]}]
BACKPORT-->
rmyz added a commit that referenced this pull request Aug 7, 2025
# Backport

This will backport the following commits from `main` to `8.17`:
- [Remove unused deps
(#230630)](#230630)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-06T11:35:50Z","message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","Team:obs-ux-infra_services","v9.2.0","dependency-reduction"],"title":"Remove
unused
deps","number":230630,"url":"https://github.com/elastic/kibana/pull/230630","mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230630","number":230630,"mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},{"url":"https://github.com/elastic/kibana/pull/230767","number":230767,"branch":"9.1","state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Aug 7, 2025
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
@mistic mistic added v9.1.2 and removed v9.1.1 labels Aug 7, 2025
rmyz added a commit that referenced this pull request Aug 8, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Remove unused deps
(#230630)](#230630)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-06T11:35:50Z","message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","Team:obs-ux-infra_services","v9.2.0","dependency-reduction"],"title":"Remove
unused
deps","number":230630,"url":"https://github.com/elastic/kibana/pull/230630","mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230630","number":230630,"mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},{"url":"https://github.com/elastic/kibana/pull/230767","number":230767,"branch":"9.1","state":"OPEN"}]}]
BACKPORT-->
rmyz added a commit that referenced this pull request Aug 8, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [Remove unused deps
(#230630)](#230630)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-06T11:35:50Z","message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","Team:obs-ux-infra_services","v9.2.0","dependency-reduction"],"title":"Remove
unused
deps","number":230630,"url":"https://github.com/elastic/kibana/pull/230630","mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230630","number":230630,"mergeCommit":{"message":"Remove
unused deps
(#230630)","sha":"62fa2c76d735f591e8cf1e8946142a0b8a78c560"}},{"url":"https://github.com/elastic/kibana/pull/230767","number":230767,"branch":"9.1","state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release dependency-reduction initiative to reduce the number of Kibana's third-party dependencies release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.10 v8.18.6 v8.19.1 v9.0.6 v9.1.2 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spacetime] Remove unused Kibana's dependencies
5 participants