[ai_assistant] remove import from kbn/test-suites-xpack #228650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v9.1.0
v9.2.0
release_note:skip
TattdCodeMonkey
approved these changes
Jul 18, 2025
csr
approved these changes
Jul 21, 2025
💚 Build Succeeded
Metrics [docs]
History
cc @dmlemeshko |
SrdjanLL
approved these changes
Jul 21, 2025
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16413884625 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 21, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 122cd9a) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/knowledge_base.ts # x-pack/test/tsconfig.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
10 tasks
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <[email protected]>
dmlemeshko
added a commit
that referenced
this pull request
Jul 22, 2025
… (#228767) # Backport This will backport the following commits from `main` to `9.1`: - [[ai_assistant] remove import from kbn/test-suites-xpack (#228650)](#228650) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-21T09:56:40Z","message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v9.2.0"],"title":"[ai_assistant] remove import from kbn/test-suites-xpack","number":228650,"url":"https://github.com/elastic/kibana/pull/228650","mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228650","number":228650,"mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <[email protected]>
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jul 25, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <[email protected]>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Aug 8, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 122cd9a) # Conflicts: # x-pack/solutions/observability/test/api_integration_deployment_agnostic/apis/ai_assistant/complete/functions/retrieve_elastic_doc.spec.ts # x-pack/solutions/observability/test/tsconfig.json # x-pack/solutions/search/test/functional/apps/search_playground/utils/create_llm_proxy.ts # x-pack/solutions/search/test/functional/apps/search_playground/utils/create_openai_chunk.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/knowledge_base.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/model_and_inference.ts # x-pack/test/functional/apps/search_playground/playground_overview.ess.ts # x-pack/test/tsconfig.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
that referenced
this pull request
Aug 11, 2025
…) (#231211) # Backport This will backport the following commits from `main` to `8.19`: - [[ai_assistant] remove import from kbn/test-suites-xpack (#228650)](#228650) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-21T09:56:40Z","message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v9.2.0","v8.19.1"],"title":"[ai_assistant] remove import from kbn/test-suites-xpack","number":228650,"url":"https://github.com/elastic/kibana/pull/228650","mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228767","number":228767,"state":"MERGED","mergeCommit":{"sha":"78e85e4734463560866d83ec81481a14d8634cae","message":"[9.1] [ai_assistant] remove import from kbn/test-suites-xpack (#228650) (#228767)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[ai_assistant] remove import from kbn/test-suites-xpack\n(#228650)](https://github.com/elastic/kibana/pull/228650)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228650","number":228650,"mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just spotted that #228009 made an import from deprecated
x-pack/testhelper.It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion)
I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to
kbn/test-suites-xpack-platform