Skip to content

Commit 5f9e4eb

Browse files
[8.19] [ai_assistant] remove import from kbn/test-suites-xpack (#228650) (#231211)
# Backport This will backport the following commits from `main` to `8.19`: - [[ai_assistant] remove import from kbn/test-suites-xpack (#228650)](#228650) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-21T09:56:40Z","message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v9.2.0","v8.19.1"],"title":"[ai_assistant] remove import from kbn/test-suites-xpack","number":228650,"url":"https://github.com/elastic/kibana/pull/228650","mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228767","number":228767,"state":"MERGED","mergeCommit":{"sha":"78e85e4734463560866d83ec81481a14d8634cae","message":"[9.1] [ai_assistant] remove import from kbn/test-suites-xpack (#228650) (#228767)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[ai_assistant] remove import from kbn/test-suites-xpack\n(#228650)](https://github.com/elastic/kibana/pull/228650)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228650","number":228650,"mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
1 parent 737a583 commit 5f9e4eb

File tree

20 files changed

+7
-1865
lines changed

20 files changed

+7
-1865
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1840,7 +1840,6 @@ x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security
18401840
/x-pack/platform/test/serverless @elastic/appex-qa
18411841
/x-pack/test/api_integration/deployment_agnostic @elastic/appex-qa
18421842
/x-pack/platform/test/functional/services/ml/api.ts @elastic/appex-qa # temporarily due to SKA tests relocation
1843-
/x-pack/test/api_integration/deployment_agnostic/apis/ @elastic/appex-qa # temporarily due to SKA tests relocation
18441843
/x-pack/solutions/observability/test/functional/config.base.ts @elastic/appex-qa
18451844
/x-pack/solutions/observability/test/functional/ftr_provider_context.d.ts @elastic/appex-qa
18461845
/x-pack/solutions/observability/test/functional/page_objects/index.ts @elastic/appex-qa

x-pack/solutions/observability/test/tsconfig.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616
"../../../../typings/**/*",
1717
"../../../../src/platform/packages/shared/kbn-test/types/ftr_globals/**/*",
1818
],
19-
"exclude": ["target/**/*", "*/plugins/**/*", "plugins/**/*"],
19+
"exclude": [
20+
"target/**/*",
21+
"*/plugins/**/*",
22+
"plugins/**/*"
23+
],
2024
"kbn_references": [
2125
"@kbn/test",
2226
"@kbn/expect",

x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/advanced_settings.ts

Lines changed: 0 additions & 26 deletions
This file was deleted.

x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/alerts.ts

Lines changed: 0 additions & 81 deletions
This file was deleted.

x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/conversation.ts

Lines changed: 0 additions & 225 deletions
This file was deleted.

0 commit comments

Comments
 (0)