fix: avoid trying to use watchman for file system watcher #16335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #14890 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
force-pushed
the
remi/14890-parcel-watcher-default-backend
branch
from
6999e7f to
d35b266
Compare
ndoschek
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Thank you for the fix @rschnekenbu! 🙌 I tested both the Electron and browser versions. On my Windows VM, the popup window issue in Electron is resolved. I also did some quick file-watching tests, which worked well as far as I could judge.
I also tested on my Linux (Ubuntu 24) system, and everything still works as expected.
Waiting for a second look from Mark before merging though.
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
rschnekenbu
added a commit
that referenced
this pull request
Sep 30, 2025
fixes #14890 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
2 tasks
rschnekenbu
added a commit
that referenced
this pull request
Sep 30, 2025
…16351) fixes #14890 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
ndoschek
pushed a commit
that referenced
this pull request
Oct 1, 2025
…16351) fixes #14890 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Avoid trying to select watchman for the various OS for File Watching.
By default, @parcel/watcher tries to use watchman as backend. For this, it tries to connect to the watchman service via socket. This opens a pop-up on windows, as there is an error message displayed when watchman is not found.
Via options, it is possible to select the backend and not let @parcel/watcher evaluate if watchman exists. Thus it avoids the popup window.
As watchman is not expected to be deployed, this should not hurt current performances. It is still possible for a particular application to deploy specific options and choose again watchman, as the parcel options can be injected via a service.
references:
@parcel/watcher priorities: https://github.com/parcel-bundler/watcher?tab=readme-ov-file#watching
@parcel/watcher code for backend selection: https://github.com/parcel-bundler/watcher/blob/8dfd99440b8666e81cc6865f68697ab272dfe83d/src/Backend.cc
@parcel/watcher code for watchman backend detection: https://github.com/parcel-bundler/watcher/blob/8dfd99440b8666e81cc6865f68697ab272dfe83d/src/watchman/WatchmanBackend.cc#L49
How to test
Build Theia sample electron application on windows with the patch and try to start the electron app. The popup should not come.
The process monitor shall also not display any cmd.exe process with watchman command triggered.
Follow-ups
potential follow-up
#15921
Breaking changes
Attribution
contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers