Log exceptions when indexing #1303 #4441
Open
+12
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to eclipse-jdt#1303
fedejeanne
force-pushed
the
log_exceptions_when_indexing_2
branch
from
cf2fa08 to
3667708
Compare
fedejeanne
commented
Sep 26, 2025
| if (VERBOSE) { | ||
| trace("-> failed to recreate index for path: "+containerPathString, e); //$NON-NLS-1$ | ||
| } | ||
| Util.log(Status.warning("Failed to recreate index for path: " + containerPathString)); //$NON-NLS-1$ |
There was a problem hiding this comment.
Note: if you check the call hierarchy of the method, you'll notice that this ends up returning false in these jobs:
Which means it is a recoverable error, ergo I just posted a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4388 (but this time for the indexing of JARs/JRTs), do not rely on the
VERBOSEflag, let the exceptions come to the error log and to the UI instead for better debugging.Notice that I logged some exceptions as warnings since the operation will be retried i.e. it's recoverable.
Contributes to #1303