Log exceptions when indexing #1303 #4388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
requested changes
Sep 11, 2025
org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/IndexAllProject.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/SaveIndex.java
Outdated
Show resolved
Hide resolved
fedejeanne
force-pushed
the
log_exceptions_when_indexing
branch
from
c35b1fd to
3b67119
Compare
Exceptions while creating the index are logged as errors and exceptions when saving the index are logged as information. Contributes to eclipse-jdt#1303
fedejeanne
force-pushed
the
log_exceptions_when_indexing
branch
from
3b67119 to
0a569aa
Compare
iloveeclipse
approved these changes
Sep 12, 2025
|
Thank you! |
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Don't rely on the
VERBOSEconfiguration to be enabled, bring the errors to the user so they are visible in the Error Log view and the error log files too.Contributes to
#1303