Reload schedule entries when changing the numbering style of an activity #8001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattmann
approved these changes
Aug 21, 2025
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
approved these changes
Aug 23, 2025
| return scheduleEntry.period().scheduleEntries().$reload() | ||
| }) | ||
| ) | ||
| this.loadScheduleEntry() |
Member
Author
There was a problem hiding this comment.
Yes. Since fcb536f we explicitly switched from a computed to local state + watcher for the scheduleEntry in this component. Reason was that this way it's more robust when deleting the schedule entry, see #4975 where this change was implemented.
I just tried again to remove this line, and the sidebar day picasso is updated, but in the main content card's title bar the numbering scheme is not updated.
| async reloadAllScheduleEntriesInRelatedPeriods() { | ||
| await Promise.all( | ||
| this.activity.scheduleEntries().items.map((scheduleEntry) => { | ||
| return scheduleEntry.period().scheduleEntries().$reload() |
Contributor
There was a problem hiding this comment.
Just as info:
Like this the scheduleEntries of a period might be loaded multiple times.
(hal-json-vuex catches this, but just as info)
This is a bugfix for the following scenario: - Load the picasso - Open the activity detail of an activity - Change the activity's category to one with a different numbering style Expected outcome: All displayed instances of the schedule entry show the schedule entry number change, and all schedule entries at all times have the correct up-to-date schedule entry number. Actual outcome: The color of the edited schedule entry changes, but the schedule entry number on the top left remains unchanged. Also, when navigating back to the picasso, the schedule entry numbering of other schedule entries is outdated.
carlobeltrame
force-pushed
the
reload-schedule-entry-numbering
branch
from
1d84370 to
61b88b9
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for the following scenario:
Expected outcome: All displayed instances of the schedule entry show the schedule entry number change, and all schedule entries at all times have the correct up-to-date schedule entry number.
Actual outcome: The color of the edited schedule entry changes, but the schedule entry number on the top left remains unchanged. Also, when navigating back to the picasso, the schedule entry numbering of other schedule entries is outdated.