Skip to content

Conversation

@manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Apr 14, 2024

Now we have a better fallback for wrong/missing ids for activities and scheduleEntries. If a scheduleEntry is not found, but the activity is found, we load the first occurring scheduleEntry of the activity. If for whatever reason we can't find the activityId, then we try to find it using the scheduleEntryId.

This now also works if we navigate from scheduleEntry A to scheduleEntry B, then delete scheduleEntry A and use the browser back. Before this would just display our 404.

Replaces #4500

@manuelmeister manuelmeister marked this pull request as draft April 14, 2024 11:01
@manuelmeister manuelmeister added the WIP Work in progress label Apr 14, 2024
@BacLuc BacLuc mentioned this pull request Apr 27, 2024
2 tasks
@manuelmeister manuelmeister force-pushed the feature/schedule-entry-editing-in-activity branch from 4ad1317 to 3fe670b Compare June 9, 2024 12:25
@manuelmeister manuelmeister added this to the Improvements (v3.2) milestone Dec 3, 2024
@manuelmeister manuelmeister changed the title WIP: Add schedule entry edit Find a solution for the deletion redirect problem Dec 3, 2024
@manuelmeister manuelmeister removed the WIP Work in progress label Dec 3, 2024
@manuelmeister manuelmeister self-assigned this Dec 3, 2024
@manuelmeister manuelmeister force-pushed the feature/schedule-entry-editing-in-activity branch 4 times, most recently from 2569d56 to 88040c3 Compare December 25, 2024 19:16
@manuelmeister manuelmeister force-pushed the feature/schedule-entry-editing-in-activity branch from 88040c3 to f1a84b6 Compare February 8, 2025 17:47
@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Feb 8, 2025
@github-actions
Copy link

github-actions bot commented Feb 8, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister changed the title Find a solution for the deletion redirect problem Edit scheduleEntry on activity view without redirection problem Feb 8, 2025
@manuelmeister manuelmeister requested a review from a team February 14, 2025 17:51
@simfeld simfeld added deploy! Creates a feature branch deployment for this PR and removed deploy! Creates a feature branch deployment for this PR labels Feb 21, 2025
Copy link
Contributor

@simfeld simfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand it fully but something doesn't quite add up in the "browser back when previous schedule entry deleted" case: it finds another scheduleEntry of the activity, but some data is not refreshed properly. See screenshot where the title and time slot matches with a green LS entry but the badge says blue LP.

image

@manuelmeister manuelmeister requested review from a team and simfeld February 23, 2025 11:05
@manuelmeister
Copy link
Member Author

@simfeld I've fixed the problem. Also some other edge cases where we don't execute requireActivityScheduleEntry (browser-back, activity switch, scheduleEntry switch)

@manuelmeister manuelmeister added this pull request to the merge queue Feb 25, 2025
Merged via the queue into ecamp:devel with commit a97b0c2 Feb 25, 2025
35 checks passed
@manuelmeister manuelmeister deleted the feature/schedule-entry-editing-in-activity branch February 25, 2025 20:42
@manuelmeister manuelmeister mentioned this pull request Feb 25, 2025
@pmattmann pmattmann mentioned this pull request Feb 25, 2025
@carlobeltrame carlobeltrame mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants