Skip to content

Do not use FETCH_EAGER #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Do not use FETCH_EAGER #6756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d9573
No Fetch-Eager
pmattmann Jan 25, 2025
46cf7d4
fix unittests
pmattmann Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/config/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ services:
tags:
- 'app.input_filter'

api_platform.doctrine.orm.query_extension.filter_eager_loading:
class: ApiPlatform\Doctrine\Orm\Extension\FilterEagerLoadingExtension
arguments:
- false

App\Serializer\Normalizer\RelatedCollectionLinkNormalizer:
decorates: 'api_platform.hal.normalizer.item'
arguments:
Expand Down
2 changes: 1 addition & 1 deletion api/src/Entity/ScheduleEntry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class ScheduleEntry extends BaseEntity implements BelongsToCampInterface {
#[AssertBelongsToSameCamp]
#[ApiProperty(example: '/periods/1a2b3c4d')]
#[Groups(['read', 'write'])]
#[ORM\ManyToOne(targetEntity: Period::class, inversedBy: 'scheduleEntries', fetch: 'EAGER')]
#[ORM\ManyToOne(targetEntity: Period::class, inversedBy: 'scheduleEntries')]
#[ORM\JoinColumn(nullable: false, onDelete: 'cascade')]
public ?Period $period = null;

Expand Down
2 changes: 1 addition & 1 deletion api/src/Entity/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ class User extends BaseEntity implements UserInterface, PasswordAuthenticatedUse
]
)]
#[Groups(['create'])]
#[ORM\OneToOne(targetEntity: Profile::class, inversedBy: 'user', cascade: ['persist'], fetch: 'EAGER')]
#[ORM\OneToOne(targetEntity: Profile::class, inversedBy: 'user', cascade: ['persist'])]
#[ORM\JoinColumn(nullable: false, unique: true, onDelete: 'restrict')]
public Profile $profile;

Expand Down
2 changes: 1 addition & 1 deletion api/tests/Api/CampCollaborations/ListCampCollaborationsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,6 @@ public function testSqlQueryCount() {
$client->enableProfiler();
$client->request('GET', '/camp_collaborations');

$this->assertSqlQueryCount($client, 22);
$this->assertSqlQueryCount($client, 28);
}
}
8 changes: 4 additions & 4 deletions ...rmance_test_EndpointPerformanceTest__testPerformanceDidNotChangeForStableEndpoints__1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/activities: 221
/activities: 223
/activities/item: 236
/activity_progress_labels: 6
/activity_progress_labels/item: 7
/activity_responsibles: 6
/activity_responsibles/item: 8
/camps: 36
/camps/item: 31
/camp_collaborations: 22
/camps/item: 45
/camp_collaborations: 38
/camp_collaborations/item: 24
/categories: 11
/categories/item: 9
Expand Down Expand Up @@ -34,7 +34,7 @@
'/activities?camp=': 213
'/activity_progress_labels?camp=': 6
'/activity_responsibles?activity.camp=': 6
'/camp_collaborations?camp=': 12
'/camp_collaborations?camp=': 25
'/camp_collaborations?activityResponsibles.activity=': 24
'/categories?camp=': 9
'/content_types?categories=': 6
Expand Down
8 changes: 4 additions & 4 deletions ...hots__/test_EndpointPerformanceTest__testPerformanceDidNotChangeForStableEndpoints__1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/activities: 21
/activities: 23
/activities/item: 36
/activity_progress_labels: 6
/activity_progress_labels/item: 7
/activity_responsibles: 6
/activity_responsibles/item: 8
/camps: 26
/camps/item: 21
/camp_collaborations: 22
/camps/item: 25
/camp_collaborations: 28
/camp_collaborations/item: 14
/categories: 11
/categories/item: 9
Expand Down Expand Up @@ -34,7 +34,7 @@
'/activities?camp=': 13
'/activity_progress_labels?camp=': 6
'/activity_responsibles?activity.camp=': 6
'/camp_collaborations?camp=': 12
'/camp_collaborations?camp=': 15
'/camp_collaborations?activityResponsibles.activity=': 14
'/categories?camp=': 9
'/content_types?categories=': 6
Expand Down
Loading