Skip to content

Conversation

@pmattmann
Copy link
Member

@pmattmann pmattmann commented Jan 25, 2025

Solves the same problem as #6720 - but differently.

We can completely dispense with eager-fetch, so that FilterEagerLoadingsExtension has no effect.
This way we don't have to undermine the ApiPlatform code.

Affected endpoints:

  • /camp/{campId}/categories
  • /camp/{campId}/checklists
  • /checklists/{checklistId}/checklist_items
  • /periods/{periodId}/days
  • /periods/{periodId}/schedule_entries
  • /days/{dayId}/day_responsibles

@pmattmann pmattmann added Meeting Discuss Am nächsten Core-Meeting besprechen Performance api-performance-test! labels Jan 25, 2025
@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label Jan 25, 2025
@github-actions
Copy link

github-actions bot commented Jan 25, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc
Copy link
Contributor

BacLuc commented Jan 25, 2025

Measurement with dev data is here: BacLuc@c8ffccf

@pmattmann
Copy link
Member Author

Measurement with dev data is here: BacLuc@c8ffccf

We should measure with the amount of data, as is the case on prod.

@BacLuc
Copy link
Contributor

BacLuc commented Jan 26, 2025

I know, but testing against prod data brings its own difficulties.
Testing against the dev and feature branch deployments was a good indicator if a change will not change much, make it way better, or make it way worse.
Here are the measurements against a prod database on my laptop. (diffed against devel, prod database, on my laptop):
BacLuc@ef8229d

some requests could not be served, transactions were aborted...?
(but that happened also with the reference of devel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR Meeting Discuss Am nächsten Core-Meeting besprechen Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants