Skip to content

Conversation

@BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Oct 17, 2024

The performance measurement part of

Start with performance tests for the api, that we can verify possible performance improvements.

Currently, the tool https://grafana.com/docs/k6 is used.

The output json is not meant as a benchmark.
Because the time is dependent on the instance (and network between and many other factors),
the output.json is not meant as a global reference, but as a relative reference.

If you have a place where you want to improve the performance,
first: run the performance tests against the instance.
then apply your change

Put result summary into a json we can diff easily for each endpoint.
That we find the url for the local db easily.
This does not end up in the docker image or in the helm deployment.
Else the results shift and are not diffable.
Use a large negative number that it is clear
that an id for a item endpoint could not be found.
@simfeld
Copy link
Contributor

simfeld commented Oct 17, 2024

was able to run this on my machine

getting lots of these errors though, is this normal?

time="2024-10-17T21:20:03Z" level=error msg="SyntaxError: invalid character '<'
looking for beginning of value\n\tat parse (native)\n\tat default
(file:///app/script.js:59:33(98))\n" executor=shared-iterations scenario=default source=stacktrace

@BacLuc
Copy link
Contributor Author

BacLuc commented Oct 19, 2024

was able to run this on my machine

getting lots of these errors though, is this normal?

time="2024-10-17T21:20:03Z" level=error msg="SyntaxError: invalid character '<'
looking for beginning of value\n\tat parse (native)\n\tat default
(file:///app/script.js:59:33(98))\n" executor=shared-iterations scenario=default source=stacktrace

This was a bug in my code.
We cannot hit certain endpoints (they don't support get or because of other reasons).
I improve it with 048a7f2

@BacLuc BacLuc requested a review from a team November 15, 2024 18:08
@BacLuc BacLuc added this pull request to the merge queue Dec 3, 2024
Merged via the queue into ecamp:devel with commit 69e8916 Dec 3, 2024
28 checks passed
@BacLuc BacLuc deleted the performance-measurement branch December 3, 2024 20:34
@carlobeltrame carlobeltrame mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants