Performance tests + switch to worker mode #6021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
performance-improvements-ecamp3
branch
from
3aaa6b0 to
18ebe33
Compare
Put result summary into a json we can diff easily for each endpoint.
That we find the url for the local db easily.
This does not end up in the docker image or in the helm deployment.
Else the results shift and are not diffable. Use a large negative number that it is clear that an id for a item endpoint could not be found.
BacLuc
force-pushed
the
performance-improvements-ecamp3
branch
from
18ebe33 to
9bbf678
Compare
BacLuc
added
the
test-flaky-e2e!
|
seems like i have to fix the http cache e2e test for invalidation first, before i can make the api faster. |
Core Meeting DecisionWe try to merge this without the last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with performance tests for the api, that we can verify possible performance improvements.
Currently, the tool https://grafana.com/docs/k6 is used.
The output json is not meant as a benchmark.
Because the time is dependent on the instance (and network between and many other factors),
the output.json is not meant as a global reference, but as a relative reference.
If you have a place where you want to improve the performance,
first: run the performance tests against the instance.
then apply your change
run the performance tests again against the same instance with the changed code.
Most endpoints got faster locally, i would say we can merge this and see the effect in production.
Issue: