Fix build status error check condition #1315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build status error check condition
Note
Fixes not-found error detection in template build status handler, removes unused DB error types, and adds an integration test for 400 on invalid ids.
errors.Aswithtemplatecache.TemplateBuildInfoNotFoundErrorfor not-found detection inpackages/api/internal/handlers/template_build_status.go.internal/cache/templatesand drop reliance onshared/pkg/dbfor this check.SnapshotNotFoundErrorandBuildNotFoundErrorfrompackages/shared/pkg/db/errors.go.tests/integration/internal/tests/api/templates/status_build_test.goasserting400 Bad Requestfor invalid template/build IDs.Written by Cursor Bugbot for commit f8c0ef1. This will update automatically on new commits. Configure here.