Fix build status error check condition (#1315)

Author: dobrac

packages/api/internal/handlers/template_build_status.go

@@ -10,9 +10,9 @@ import (
 	"github.com/google/uuid"
 
 	"github.com/e2b-dev/infra/packages/api/internal/api"
+	templatecache "github.com/e2b-dev/infra/packages/api/internal/cache/templates"
 	"github.com/e2b-dev/infra/packages/api/internal/utils"
 	"github.com/e2b-dev/infra/packages/db/types"
-	"github.com/e2b-dev/infra/packages/shared/pkg/db"
 	"github.com/e2b-dev/infra/packages/shared/pkg/logs"
 	"github.com/e2b-dev/infra/packages/shared/pkg/models/envbuild"
 	"github.com/e2b-dev/infra/packages/shared/pkg/telemetry"
@@ -32,7 +32,8 @@ func (a *APIStore) GetTemplatesTemplateIDBuildsBuildIDStatus(c *gin.Context, tem
 
 	buildInfo, err := a.templateBuildsCache.Get(ctx, buildUUID, templateID)
 	if err != nil {
-		if errors.Is(err, db.TemplateBuildNotFoundError{}) {
+		var notFoundErr templatecache.TemplateBuildInfoNotFoundError
+		if errors.As(err, &notFoundErr) {
 			a.sendAPIStoreError(c, http.StatusBadRequest, fmt.Sprintf("Build '%s' not found", buildUUID))
 			return
 		}

packages/shared/pkg/db/errors.go

@@ -8,18 +8,6 @@ func (TemplateBuildNotFoundError) Error() string {
 	return "Template build not found"
 }
 
-type SnapshotNotFoundError struct{ NotFoundError }
-
-func (SnapshotNotFoundError) Error() string {
-	return "Snapshot not found"
-}
-
-type BuildNotFoundError struct{ NotFoundError }
-
-func (BuildNotFoundError) Error() string {
-	return "Build not found"
-}
-
 type EnvNotFoundError struct{ NotFoundError }
 
 func (EnvNotFoundError) Error() string {

tests/integration/internal/tests/api/templates/status_build_test.go

@@ -0,0 +1,24 @@
+package api_templates
+
+import (
+	"net/http"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/e2b-dev/infra/tests/integration/internal/setup"
+)
+
+func TestInvalidBuildStatus(t *testing.T) {
+	c := setup.GetAPIClient()
+
+	resp, err := c.GetTemplatesTemplateIDBuildsBuildIDStatusWithResponse(
+		t.Context(),
+		"non-existing",
+		"also-non-existing",
+		nil,
+		setup.WithAccessToken(),
+	)
+	require.NoError(t, err)
+	require.Equal(t, http.StatusBadRequest, resp.StatusCode())
+}