Fix running sandboxes pagination

[dobrac]

Fix running sandboxes pagination. The running sandboxes were not sorted when limit was applied, causing missing sandboxes in the result set and improper token pagination.

[linear]

E2B-3011 Pagination of running sandboxes ends prematurely

[jakubno]

wouldn't it be more error prone to sort in the filter based on cursor function?

[cursor]

Bug: Sandbox Pagination Fails Due to Premature Filtering

Pagination is incorrect because cursor filtering is applied to individual sandbox lists before the final merge and sort. Also, paused sandboxes are prematurely limited at the database level, which can exclude them from the final paginated results.

packages/api/internal/handlers/sandboxes_list.go#L162-L180

infra/packages/api/internal/handlers/sandboxes_list.go

Lines 162 to 180 in dfe3d7f

	// Filter based on cursor
	runningSandboxList = utils.FilterBasedOnCursor(runningSandboxList, cursorTime, cursorID)
	sandboxes = append(sandboxes, runningSandboxList...)
	}
	if slices.Contains(states, api.Paused) {
	pausedSandboxList, err := a.getPausedSandboxes(ctx, team.ID, runningSandboxesIDs, metadataFilter, limit, cursorTime, cursorID)
	if err != nil {
	zap.L().Error("Error getting paused sandboxes", zap.Error(err))
	a.sendAPIStoreError(c, http.StatusInternalServerError, "Error getting paused sandboxes")
	return
	}
	pausingSandboxList := instanceInfoToPaginatedSandboxes(sandboxesInCache[instance.StatePausing])
	pausingSandboxList = utils.FilterSandboxesOnMetadata(pausingSandboxList, metadataFilter)
	pausingSandboxList = utils.FilterBasedOnCursor(pausingSandboxList, cursorTime, cursorID)

 

---

[dobrac]

Bug: Sandbox Pagination Fails Due to Premature Filtering

Pagination is incorrect because cursor filtering is applied to individual sandbox lists before the final merge and sort. Also, paused sandboxes are prematurely limited at the database level, which can exclude them from the final paginated results.

packages/api/internal/handlers/sandboxes_list.go#L162-L180

infra/packages/api/internal/handlers/sandboxes_list.go

Lines 162 to 180 in dfe3d7f

	// Filter based on cursor
	runningSandboxList = utils.FilterBasedOnCursor(runningSandboxList, cursorTime, cursorID)
	sandboxes = append(sandboxes, runningSandboxList...)
	}
	if slices.Contains(states, api.Paused) {
	pausedSandboxList, err := a.getPausedSandboxes(ctx, team.ID, runningSandboxesIDs, metadataFilter, limit, cursorTime, cursorID)
	if err != nil {
	zap.L().Error("Error getting paused sandboxes", zap.Error(err))
	a.sendAPIStoreError(c, http.StatusInternalServerError, "Error getting paused sandboxes")
	return
	}
	pausingSandboxList := instanceInfoToPaginatedSandboxes(sandboxesInCache[instance.StatePausing])
	pausingSandboxList = utils.FilterSandboxesOnMetadata(pausingSandboxList, metadataFilter)
	pausingSandboxList = utils.FilterBasedOnCursor(pausingSandboxList, cursorTime, cursorID)

 

I don't think this comment is correct