remove the limit from FilterBasedOnCursor

Author: dobrac

packages/api/internal/handlers/sandboxes_list.go

@@ -160,8 +160,8 @@ func (a *APIStore) GetV2Sandboxes(c *gin.Context, params api.GetV2SandboxesParam
 		// Set the total (before we apply the limit, but already with all filters)
 		c.Header("X-Total-Running", strconv.Itoa(len(runningSandboxList)))
 
-		// Filter based on cursor and limit
-		runningSandboxList = utils.FilterBasedOnCursor(runningSandboxList, cursorTime, cursorID, limit)
+		// Filter based on cursor
+		runningSandboxList = utils.FilterBasedOnCursor(runningSandboxList, cursorTime, cursorID)
 
 		sandboxes = append(sandboxes, runningSandboxList...)
 	}
@@ -177,7 +177,7 @@ func (a *APIStore) GetV2Sandboxes(c *gin.Context, params api.GetV2SandboxesParam
 
 		pausingSandboxList := instanceInfoToPaginatedSandboxes(sandboxesInCache[instance.StatePausing])
 		pausingSandboxList = utils.FilterSandboxesOnMetadata(pausingSandboxList, metadataFilter)
-		pausingSandboxList = utils.FilterBasedOnCursor(pausingSandboxList, cursorTime, cursorID, limit)
+		pausingSandboxList = utils.FilterBasedOnCursor(pausingSandboxList, cursorTime, cursorID)
 
 		sandboxes = append(sandboxes, pausedSandboxList...)
 		sandboxes = append(sandboxes, pausingSandboxList...)

packages/api/internal/utils/sandboxes_list.go

@@ -76,7 +76,7 @@ func ParseCursor(cursor string) (time.Time, string, error) {
 	return cursorTime, parts[1], nil
 }
 
-func FilterBasedOnCursor(sandboxes []PaginatedSandbox, cursorTime time.Time, cursorID string, limit int32) []PaginatedSandbox {
+func FilterBasedOnCursor(sandboxes []PaginatedSandbox, cursorTime time.Time, cursorID string) []PaginatedSandbox {
 	// Apply cursor-based filtering if cursor is provided
 	var filteredSandboxes []PaginatedSandbox
 	for _, sandbox := range sandboxes {
@@ -87,17 +87,8 @@ func FilterBasedOnCursor(sandboxes []PaginatedSandbox, cursorTime time.Time, cur
 			filteredSandboxes = append(filteredSandboxes, sandbox)
 		}
 	}
-	sandboxes = filteredSandboxes
 
-	// Sort the sandboxes to apply limit correctly
-	SortPaginatedSandboxesDesc(sandboxes)
-
-	// Apply limit (get limit + 1 for pagination if possible)
-	if len(sandboxes) > int(limit) {
-		sandboxes = sandboxes[:limit+1]
-	}
-
-	return sandboxes
+	return filteredSandboxes
 }
 
 // SortPaginatedSandboxesDesc sorts the sandboxes by StartedAt (descending),