-
Notifications
You must be signed in to change notification settings - Fork 182
Save auto pause option to the DB #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61fde24 to
32700e8
Compare
dobrac
requested changes
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
can you add test please?
9b1d7cd to
c304511
Compare
dobrac
requested changes
Aug 18, 2025
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
tests/integration/internal/tests/api/sandbox_auto_pause_test.go
Outdated
Show resolved
Hide resolved
dobrac
requested changes
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a cleanup for the last resumed sandbox
EDIT: Sorry, it will be cleaned up as it's the same sandbox
dobrac
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Save info about auto pause to DB, so users don't need to pass it everytime