Save auto pause option to the DB (#1008)

Author: jakubno

.github/workflows/lint.yml

@@ -14,9 +14,6 @@ jobs:
       modules: ${{ steps.set-modules.outputs.modules }}
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: 'go.work'
       - id: set-modules
         run: echo "modules=$(go list -m -json | jq -s '.' | jq -c '[.[].Dir]')" >> $GITHUB_OUTPUT
 

packages/api/internal/api/spec.gen.go

@@ -66,11 +66,6 @@ func (a *APIStore) PostSandboxesSandboxIDResume(c *gin.Context, sandboxID api.Sa
 		}
 	}
 
-	autoPause := instance.InstanceAutoPauseDefault
-	if body.AutoPause != nil {
-		autoPause = *body.AutoPause
-	}
-
 	sandboxID = utils.ShortID(sandboxID)
 
 	// This is also checked during in orchestrator.CreateSandbox, where the sandbox ID is reserved,
@@ -80,7 +75,6 @@ func (a *APIStore) PostSandboxesSandboxIDResume(c *gin.Context, sandboxID api.Sa
 		zap.L().Debug("Sandbox is already running",
 			logger.WithSandboxID(sandboxID),
 			zap.Time("end_time", sbxCache.GetEndTime()),
-			zap.Bool("auto_pause", sbxCache.AutoPause.Load()),
 			zap.Time("start_time", sbxCache.StartTime),
 			zap.String("node_id", sbxCache.Node.NodeID),
 		)
@@ -102,6 +96,10 @@ func (a *APIStore) PostSandboxesSandboxIDResume(c *gin.Context, sandboxID api.Sa
 		return
 	}
 
+	autoPause := lastSnapshot.Snapshot.AutoPause
+	if body.AutoPause != nil {
+		autoPause = *body.AutoPause
+	}
 	snap := lastSnapshot.Snapshot
 	build := lastSnapshot.EnvBuild
 

packages/api/internal/api/types.gen.go

@@ -142,7 +142,7 @@ func (o *Orchestrator) CreateSandbox(
 			RamMb:               build.RamMb,
 			Vcpu:                build.Vcpu,
 			Snapshot:            isResume,
-			AutoPause:           &autoPause,
+			AutoPause:           autoPause,
 			AllowInternetAccess: allowInternetAccess,
 			TotalDiskSizeMb:     ut.FromPtr(build.TotalDiskSizeMb),
 		},

packages/api/internal/handlers/sandbox_resume.go

@@ -52,11 +52,6 @@ func (o *Orchestrator) getSandboxes(ctx context.Context, node *nNode.NodeInfo) (
 			return nil, fmt.Errorf("failed to parse build ID '%s' for job: %w", config.BuildId, err)
 		}
 
-		autoPause := instance.InstanceAutoPauseDefault
-		if config.AutoPause != nil {
-			autoPause = *config.AutoPause
-		}
-
 		sandboxesInfo = append(
 			sandboxesInfo,
 			instance.NewInstanceInfo(
@@ -78,7 +73,7 @@ func (o *Orchestrator) getSandboxes(ctx context.Context, node *nNode.NodeInfo) (
 				config.FirecrackerVersion,
 				config.EnvdVersion,
 				node,
-				autoPause,
+				config.AutoPause,
 				config.EnvdAccessToken,
 				config.AllowInternetAccess,
 				config.BaseTemplateId,

packages/api/internal/orchestrator/create_instance.go

@@ -0,0 +1,12 @@
+-- +goose Up
+-- +goose StatementBegin
+
+ALTER TABLE snapshots
+    ADD COLUMN auto_pause boolean NOT NULL default false;
+-- +goose StatementEnd
+
+-- +goose Down
+-- +goose StatementBegin
+ALTER TABLE snapshots
+    DROP COLUMN IF EXISTS auto_pause;
+-- +goose StatementEnd