Checksummed icons #586
Merged
Checksummed icons #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g_strcmp0 handles NULL values correctly. This allows to omit NULL pointer checks, which would be otherwise crucial.
tsipinakis
requested changes
Jan 8, 2019
|
|
||
| gsize len_expected; | ||
| gsize len_actual; | ||
| gsize pixelstride; |
Member
There was a problem hiding this comment.
Why is rowstride an int but pixelstride gsize? Just seemed inconsistent.
Member
Author
There was a problem hiding this comment.
Actually both should be a gsize or size_t. But the gdk pixbuf requires an int and the GVariant stores an int for the rowstride.
bebehei
force-pushed
the
checksummed-icons
branch
from
0886f92 to
5748c41
Compare
tsipinakis
requested changes
Jan 10, 2019
src/notification.c
Outdated
| if (STR_EMPTY(n->iconname)) | ||
| g_clear_pointer(&n->iconname, g_free); | ||
| if (!n->icon && n->iconname) | ||
| n->icon = icon_get_for_name(n->iconname, &n->icon_id); |
Member
There was a problem hiding this comment.
Missed one here, this call doesn't scale the icon.
EDIT: I think this is a hint to maybe put all the icon parsing in one place to be able to manage them.
Member
Author
There was a problem hiding this comment.
EDIT: I think this is a hint to maybe put all the icon parsing in one place to be able to manage them.
Valid point. This already exists. I just had to use the right function.
bebehei
force-pushed
the
checksummed-icons
branch
from
5748c41 to
2321084
Compare
Currently, we just skipped the notification comparison, if the notification had a raw icon attached. This is a bit counterintuitive. Calculating a checksum of the raw icon's data is the solution. For that we cache the pixel buffer and introduce a field, which saves the current icon's id. The icon_id may be a path or a hash. So you can compare two notifications by their icon_id field regardless of their icon type by their icon_id field.
bebehei
force-pushed
the
checksummed-icons
branch
from
2321084 to
6f8b53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #571