Change the caching of icons #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This was referenced Apr 28, 2025
Useful mainly for testing, should not affect legit icon names
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1473 +/- ##
==========================================
- Coverage 64.83% 64.75% -0.09%
==========================================
Files 51 51
Lines 9010 9053 +43
Branches 1055 1066 +11
==========================================
+ Hits 5842 5862 +20
- Misses 3168 3191 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
this is not working out the way I intended. maybe icon_id should be scrapped altogether.. |
Contributor
Author
|
@fwsmit if you have the time could you check if these changes are sound? the testing does work, but I did change some pretty critical parts |
mnpqraven
added a commit
to mnpqraven/dotfiles_nix
that referenced
this pull request
May 15, 2025
mnpqraven
added a commit
to mnpqraven/dotfiles_nix
that referenced
this pull request
May 15, 2025
* initial * default exec-once for bars * use mpd instead of mpris * lint(css) with biome * chore * update scripts * initial with portal bug * fcitx5 breaking portal at boot, see NixOS/nixpkgs#206630 * fix fcitx5 killing portals by using nixos module * initial * default exec-once for bars * use mpd instead of mpris * lint(css) with biome * chore * update scripts * initial with portal bug * fcitx5 breaking portal at boot, see NixOS/nixpkgs#206630 * fix fcitx5 killing portals by using nixos module * waybar mpd: disable blinking animation * overlay to resolve icon bug for stacked dunst notifications dunst-project/dunst#1473 * omit path * feat(dunst)
mnpqraven
added a commit
to mnpqraven/dotfiles_nix
that referenced
this pull request
May 15, 2025
* initial * default exec-once for bars * use mpd instead of mpris * lint(css) with biome * chore * update scripts * initial with portal bug * fcitx5 breaking portal at boot, see NixOS/nixpkgs#206630 * fix fcitx5 killing portals by using nixos module * initial * default exec-once for bars * use mpd instead of mpris * lint(css) with biome * chore * update scripts * initial with portal bug * fcitx5 breaking portal at boot, see NixOS/nixpkgs#206630 * fix fcitx5 killing portals by using nixos module * waybar mpd: disable blinking animation * overlay to resolve icon bug for stacked dunst notifications dunst-project/dunst#1473 * omit path * feat(dunst)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.