Skip to content

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Aug 26, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211143744149998?focus=true

Description

Moves ping to entry point, then routes the update through into the args.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

github-actions bot commented Aug 26, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit caef3ed
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68b81068805084000857b1ca

Copy link

github-actions bot commented Aug 26, 2025

[Beta] Generated file diff

Time updated: Wed, 03 Sep 2025 09:55:36 GMT

Android
    - android/adsjsContentScope.js
  • android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js
  • android/pages/duckplayer/dist/index.js

File has changed

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js
  • apple/pages/duckplayer/dist/index.js
  • apple/pages/duckplayer/index.html
  • apple/pages/history/dist/index.js
  • apple/pages/new-tab/dist/index.js
  • apple/pages/onboarding/dist/index.js
  • apple/pages/release-notes/dist/index.js
  • apple/pages/special-error/dist/index.js
  • apple/pages/special-error/index.html

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js
  • integration/pages/duckplayer/dist/index.js
  • integration/pages/example/dist/index.js
  • integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.js
  • integration/pages/onboarding/dist/index.js
  • integration/pages/release-notes/dist/index.js
  • integration/pages/special-error/dist/index.js

File has changed

Windows
    - windows/contentScope.js
  • windows/pages/duckplayer/dist/index.js
  • windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.js
  • windows/pages/onboarding/dist/index.js
  • windows/pages/release-notes/dist/index.js
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/index.html

File has changed

@jonathanKingston jonathanKingston changed the title PoC: Jkt/adsjs ping changes adsjs ping changes Aug 30, 2025
@jonathanKingston jonathanKingston marked this pull request as ready for review September 1, 2025 18:50
@jonathanKingston jonathanKingston requested a review from a team as a code owner September 1, 2025 18:50
cursor[bot]

This comment was marked as outdated.

@jonathanKingston jonathanKingston marked this pull request as draft September 1, 2025 21:41
@jonathanKingston
Copy link
Contributor Author

Sorry forgot I needed to fix the timing issues with the viewport integration tests.

shakyShane
shakyShane previously approved these changes Sep 3, 2025
@jonathanKingston jonathanKingston marked this pull request as ready for review September 3, 2025 09:54
@jonathanKingston jonathanKingston added this pull request to the merge queue Sep 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2025
@jonathanKingston jonathanKingston added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 4678800 Sep 3, 2025
13 of 17 checks passed
@jonathanKingston jonathanKingston deleted the jkt/adsjs-ping-changes branch September 3, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants