Add support for addDocumentStartJavaScript #6600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 18, 2025
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
from
5ef0a29 to
9ec7474
Compare
30 tasks
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
from
3614817 to
06fdfe5
Compare
3 tasks
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
8 times, most recently
from
6d226d6 to
fd8e009
Compare
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
6 times, most recently
from
943d09f to
28e9d6b
Compare
marcosholgado
approved these changes
Sep 3, 2025
app/src/main/java/com/duckduckgo/app/browser/BrowserWebViewClient.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserWebViewClient.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/RealWebViewCompatWrapper.kt
Show resolved
Hide resolved
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
2 times, most recently
from
925b63a to
69ff547
Compare
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
2 times, most recently
from
b45ad03 to
55b4e88
Compare
CrisBarreiro
force-pushed
the
cris/adsjs/support-adsjs
branch
from
55b4e88 to
5dc0e7f
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/1205008441501016/task/1211092095433618?focus=true ### Description * C-S-S sends us a ping message so we have a reference to a reply proxy that we store and use to send messages after a user action is initiated on the native side * Process messages by context, then feature, and then method * Refactor message posting fallback mechanism * Make scoping/instancing explicit ### Steps to test this PR **Pre-requisites** - [x] Install C-S-S 11.15.0 - [x] Load privacy-config from https://duckduckgo.github.io/privacy-configuration/pr-3624/v4/android-config.json - [x] Set version to 5.300.1 in version.properties - [x] Add logs to `WebViewCompatBreakageContentScopeJsMessageHandler#process` and `WebViewCompatWebCompatMessagingPlugin#postMessage` - [x] Enable `useNewWebCompatApis` under feature flag inventory (enabled by default) _Desktop mode_ - [x] Load wikipedia.org - [x] Open menu - [x] Switch to desktop mode - [x] Check desktop mode is loaded _Breakage reporting_ - [x] Load a page - [x] Open menu - [x] Check subscription with name `getBreakageReportValues` is sent, and message with method `breakageReportResult` is received _Disable protections_ - [x] Load http://privacy-test-pages.site/privacy-protections/gpc/ - [x] Click start test - [x] Check: - [x] `top frame header - "1"` - [x] `top frame JS API - true` - [x] `frame JS API - true` - [x] Open menu - [x] Click Disable Privacy Protection - [x] Click start test - [x] Check: - [x] `top frame header - ...` - [x] `top frame JS API - ...` - [x] `frame JS API - ...` _Feature enabled_ - [x] Enable `useNewWebCompatApis` under feature flag inventory (enabled by default) - [x] Open https://w3c.github.io/web-share/demos/share-files.html - [x] Click "Share" - [x] Dismiss native share popup - [x] Check message displayed: "Error sharing: Abort Error: Share canceled" ### UI changes n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1205008441501016/task/1211044367033330?focus=true
Description
addDocumentStartJavaScript, keeping support foractiveExperimentscompatible with bothaddDocumentStartJavaScriptandevaluateJavaScriptSteps to test this PR
Pre-requisites
WebViewCompatBreakageContentScopeJsMessageHandler#processandWebViewCompatWebCompatMessagingPlugin#postMessageuseNewWebCompatApisunder feature flag inventory (enabled by default)Desktop mode
Breakage reporting
getBreakageReportValuesis sent, and message with methodbreakageReportResultis receivedDisable protections
top frame header - "1"top frame JS API - trueframe JS API - truetop frame header - ...top frame JS API - ...frame JS API - ...Feature enabled
useNewWebCompatApisunder feature flag inventory (enabled by default)Feature enabled
useNewWebCompatApisunder feature flag inventory (enabled by default)frame JS API - trueFeature disabled
useNewWebCompatApisunder feature flag inventory (enabled by default)frame JS API - ...Feature enabled
useNewWebCompatApisunder feature flag inventory (enabled by default)DebugFlagGlobalHandler addDebugFlag: fingerprintingScreenSizeUI changes
No UI changes