Skip to content

Move DataGridViewChooseDataSourceActionList into a separate file #13397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Move DataGridViewChooseDataSourceActionList into a separate file #13397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions ...ystem/Windows/Forms/Design/DataGridViewDesigner.DataGridViewChooseDataSourceActionList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.ComponentModel;
using System.ComponentModel.Design;
using System.Drawing.Design;

namespace System.Windows.Forms.Design;

internal partial class DataGridViewDesigner
{
[ComplexBindingProperties("DataSource", "DataMember")]
private class DataGridViewChooseDataSourceActionList : DesignerActionList
{
private readonly DataGridViewDesigner _owner;

public DataGridViewChooseDataSourceActionList(DataGridViewDesigner owner) : base(owner.Component)
{
_owner = owner;
}

// The choose data source designer action item is missing
public override DesignerActionItemCollection GetSortedActionItems()
{
DesignerActionItemCollection items = [];
DesignerActionPropertyItem chooseDataSource = new(
nameof(DataSource),
SR.DataGridViewChooseDataSource)
{
RelatedComponent = _owner.Component
};

items.Add(chooseDataSource);
return items;
}

[AttributeProvider(typeof(IListSource))]
[Editor($"System.Windows.Forms.Design.DataSourceListEditor, {AssemblyRef.SystemDesign}", typeof(UITypeEditor))]
public object? DataSource
{
// Use the shadow property which is defined on the designer.
get => _owner.DataSource;
set
{
// left to do: transaction stuff
DataGridView dataGridView = _owner.Control;
IDesignerHost? host = dataGridView.Site?.GetService<IDesignerHost>();
PropertyDescriptor? dataSourceProp = TypeDescriptor.GetProperties(dataGridView)["DataSource"];
IComponentChangeService? changeService = dataGridView.Site?.GetService<IComponentChangeService>();
DesignerTransaction? transaction = host?.CreateTransaction(string.Format(SR.DataGridViewChooseDataSourceTransactionString, dataGridView.Name));
try
{
changeService?.OnComponentChanging(_owner.Component, dataSourceProp);
// Use the shadow property which is defined on the designer.
_owner.DataSource = value;
changeService?.OnComponentChanged(_owner.Component, dataSourceProp, null, null);
transaction?.Commit();
transaction = null;
}
finally
{
transaction?.Cancel();
}
}
}
}
}
58 changes: 1 addition & 57 deletions src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewDesigner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@
using System.Collections;
using System.ComponentModel.Design;
using System.Drawing;
using System.Drawing.Design;

namespace System.Windows.Forms.Design;

internal class DataGridViewDesigner : ControlDesigner
internal partial class DataGridViewDesigner : ControlDesigner
{
protected DesignerVerbCollection? designerVerbs;

Expand Down Expand Up @@ -805,61 +804,6 @@ private DialogResult ShowDialog(Form dialog)
}
}

[ComplexBindingProperties("DataSource", "DataMember")]
private class DataGridViewChooseDataSourceActionList : DesignerActionList
{
private readonly DataGridViewDesigner _owner;

public DataGridViewChooseDataSourceActionList(DataGridViewDesigner owner) : base(owner.Component)
{
_owner = owner;
}

public override DesignerActionItemCollection GetSortedActionItems()
{
DesignerActionItemCollection items = [];
DesignerActionPropertyItem chooseDataSource = new(
nameof(DataSource),
SR.DataGridViewChooseDataSource)
{
RelatedComponent = _owner.Component
};

items.Add(chooseDataSource);
return items;
}

[AttributeProvider(typeof(IListSource))]
[Editor($"System.Windows.Forms.Design.DataSourceListEditor, {AssemblyRef.SystemDesign}", typeof(UITypeEditor))]
public object? DataSource
{
// Use the shadow property which is defined on the designer.
get => _owner.DataSource;
set
{
// left to do: transaction stuff
DataGridView dataGridView = _owner.Control;
IDesignerHost? host = dataGridView.Site?.GetService<IDesignerHost>();
PropertyDescriptor? dataSourceProp = TypeDescriptor.GetProperties(dataGridView)["DataSource"];
IComponentChangeService? changeService = dataGridView.Site?.GetService<IComponentChangeService>();
DesignerTransaction? transaction = host?.CreateTransaction(string.Format(SR.DataGridViewChooseDataSourceTransactionString, dataGridView.Name));
try
{
changeService?.OnComponentChanging(_owner.Component, dataSourceProp);
// Use the shadow property which is defined on the designer.
_owner.DataSource = value;
changeService?.OnComponentChanged(_owner.Component, dataSourceProp, null, null);
transaction?.Commit();
transaction = null;
}
finally
{
transaction?.Cancel();
}
}
}
}

private class DataGridViewColumnEditingActionList : DesignerActionList
{
private readonly DataGridViewDesigner _owner;
Expand Down