Move DataGridViewChooseDataSourceActionList into a separate file
#13397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related dotnet#13231 ## Root Cause - Missing ## Proposed changes - Move `DataGridViewChooseDataSourceActionList` into a separate file - Add comment about missing structure for choosing data source designer action item. ## Customer Impact - None ## Regression? - No ## Risk - Minimal ## Test environment(s) - 10.0.100-preview.3.25201.16
ricardobossan
added
the
waiting-review
There was a problem hiding this comment.
Pull Request Overview
This PR moves the DataGridViewChooseDataSourceActionList from the DataGridViewDesigner.cs file into its own separate file and adds a comment regarding the missing structure for the data source designer action item.
- Removed the nested DataGridViewChooseDataSourceActionList from DataGridViewDesigner.cs and marked DataGridViewDesigner as partial.
- Introduced a new file (DataGridViewDesigner.DataGridViewChooseDataSourceActionList.cs) containing the moved DataGridViewChooseDataSourceActionList along with a comment on the missing structure.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DataGridViewDesigner.cs | Removed the nested DataGridViewChooseDataSourceActionList and marked the class as partial to support the split. |
| DataGridViewDesigner.DataGridViewChooseDataSourceActionList.cs | Added the separated DataGridViewChooseDataSourceActionList with minimal changes to functionality and a comment about incomplete transaction handling. |
...c/System/Windows/Forms/Design/DataGridViewDesigner.DataGridViewChooseDataSourceActionList.cs
Show resolved
Hide resolved
...c/System/Windows/Forms/Design/DataGridViewDesigner.DataGridViewChooseDataSourceActionList.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13397 +/- ##
===================================================
+ Coverage 62.72868% 62.74368% +0.01500%
===================================================
Files 1561 1562 +1
Lines 159997 159997
Branches 14918 14918
===================================================
+ Hits 100364 100388 +24
+ Misses 58857 58834 -23
+ Partials 776 775 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Epica3055
approved these changes
Apr 30, 2025
dotnet-policy-service
bot
removed
the
waiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13231
Root Cause
Proposed changes
DataGridViewChooseDataSourceActionListinto a separate fileCustomer Impact
Regression?
Risk
Test environment(s)
Microsoft Reviewers: Open in CodeFlow