Skip to content

Port DataGridViewColumnCollectionEditor #12925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 27, 2025
Merged

Port DataGridViewColumnCollectionEditor #12925

merged 10 commits into from
Feb 27, 2025

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Feb 12, 2025 •
edited by LeafShi1
Loading

Fix #12954

Port DataGridViewColumnCollectionEditor

image
image

Microsoft Reviewers: Open in CodeFlow

@Epica3055 Epica3055 requested a review from a team as a code owner February 12, 2025 06:30
@Epica3055 Epica3055 requested a review from Copilot February 12, 2025 06:32
Copilot
Copilot AI reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (14)
  • src/System.Windows.Forms.Design/src/Resources/SR.resx: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.cs.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.de.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.es.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.fr.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.it.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.ja.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.ko.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.pl.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.pt-BR.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.ru.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.tr.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.zh-Hans.xlf: Language not supported
  • src/System.Windows.Forms.Design/src/Resources/xlf/SR.zh-Hant.xlf: Language not supported

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.08822%. Comparing base (dd64431) to head (e3975ef).
Report is 68 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12925         +/-   ##
===================================================
+ Coverage   76.07869%   76.08822%   +0.00953%     
===================================================
  Files           3260        3274         +14     
  Lines         642402      643737       +1335     
  Branches       47314       47441        +127     
===================================================
+ Hits          488731      489808       +1077     
- Misses        150120      150355        +235     
- Partials        3551        3574         +23
Flag Coverage Δ
Debug 76.08822% <60.52632%> (+0.00953%) ⬆️
integration 18.01363% <0.00000%> (-0.05544%) ⬇️
production 50.09472% <37.50000%> (+0.07039%) ⬆️
test 96.95294% <100.00000%> (-0.00066%) ⬇️
unit 47.54343% <37.50000%> (+0.09443%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardobossan
ricardobossan reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, LGTM!

@Tanya-Solyanik
Copy link
Contributor

Please add unit tests

@Epica3055 Epica3055 force-pushed the Port_DataGridViewColumnCollectionEditor branch from bde4663 to 28d7e94 Compare February 13, 2025 07:35
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Feb 13, 2025
@LeafShi1 LeafShi1 mentioned this pull request Feb 14, 2025
Closed
73 tasks
@Epica3055 Epica3055 force-pushed the Port_DataGridViewColumnCollectionEditor branch from 28d7e94 to df52aea Compare February 14, 2025 01:41
ricardobossan

This comment was marked as off-topic.

Sign in to view

@ricardobossan ricardobossan dismissed their stale review February 14, 2025 15:31

There are failing tests

ricardobossan
ricardobossan reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address failing checks

@Tanya-Solyanik
Copy link
Contributor

@Epica3055 - Please make sure to test this editor on HDPI system with different screen resolutions. You can use our scratch projects, they are set to PerMonitorv2, please test both in PerMonitorV2 and SystemAware mode.

@Epica3055
Copy link
Member Author

@Tanya-Solyanik
If the Column is edited in runtime, nothing will happen when we click the button. same behavior as .Net Framework.

image

@Epica3055 Epica3055 removed the waiting-author-feedback The team requires more information from the author label Feb 18, 2025
@Tanya-Solyanik
Copy link
Contributor

@Epica3055 - please enable newly available editors as inline data in this test - EnsureUITypeEditorForProperty . This can be done in the next PR or as a part of this one.

@Tanya-Solyanik
Copy link
Contributor

@Tanya-Solyanik If the Column is edited in runtime, nothing will happen when we click the button. same behavior as .Net Framework.

image

I see , the dialog can't start unless the editor service is available.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Feb 22, 2025
@Epica3055 Epica3055 removed the waiting-author-feedback The team requires more information from the author label Feb 25, 2025
@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Feb 26, 2025
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback and removed waiting-review This item is waiting on review by one or more members of team labels Feb 26, 2025
Tanya-Solyanik
Tanya-Solyanik approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@Epica3055 Epica3055 merged commit cbdd4e7 into dotnet:main Feb 27, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 27, 2025
@Nora-Zhou01
Copy link
Contributor

Nora-Zhou01 commented Mar 6, 2025 •
edited
Loading

Verified this issue in the Winforms main branch for .NET10.0, now DataGridViewColumnCollectionEditor is supported in runtime.
1

12925-2

LeafShi1 pushed a commit to LeafShi1/winforms that referenced this pull request Mar 6, 2025
@Epica3055 @LeafShi1
Port DataGridViewColumnCollectionEditor (dotnet#12925)
b9d3398 
* Port DataGridViewColumnCollectionEditor

* fix unit test

* fix comments

* add unit test

* fix comment

* address comments

* fix comments

* fix comments

* fix comments

* fix comments
@Epica3055 Epica3055 mentioned this pull request Mar 25, 2025
Closed
@Philip-Wang01
Copy link
Contributor

Verified the issue with the latest WinForms repo from release/10.0-preview3 branch, now DataGridViewColumnCollectionEditor is supported in runtime.

@LeafShi1 LeafShi1 mentioned this pull request Mar 27, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardobossan ricardobossan ricardobossan left review comments

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Epica3055 Epica3055

Labels
None yet
Projects
None yet
Milestone
10.0 Preview3
Development

Successfully merging this pull request may close these issues.

Port DataGridViewColumnCollectionEditor
6 participants
@Epica3055 @Tanya-Solyanik @Nora-Zhou01 @Philip-Wang01 @ricardobossan @LeafShi1