-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Fix RefreshView Command executes multiple times when IsRefreshing is set to True #31471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PureWeen
merged 8 commits into
dotnet:inflight/current
from
devanathan-vaithiyanathan:fix-31375
Sep 11, 2025
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e275cdf
fix added
devanathan-vaithiyanathan f30d335
Update RefreshViewHandler.Windows.cs
devanathan-vaithiyanathan d99cebc
Update RefreshViewHandler.Windows.cs
devanathan-vaithiyanathan 72a1e24
Update RefreshViewHandler.Windows.cs
devanathan-vaithiyanathan 00f0dc3
test case added
devanathan-vaithiyanathan 7ff2d28
Update RefreshViewHandler.Windows.cs
devanathan-vaithiyanathan 2f50b55
Update Issue31375.cs
devanathan-vaithiyanathan 058915d
Update Issue31375.cs
devanathan-vaithiyanathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| using System.Windows.Input; | ||
|
|
||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 31375, "[Windows] RefreshView Command executes multiple times when IsRefreshing is set to True", PlatformAffected.UWP)] | ||
| public class Issue31375 : ContentPage | ||
| { | ||
| bool _isLoading = false; | ||
| Label _textLabel; | ||
| int count = 0; | ||
|
|
||
| public bool IsLoading | ||
| { | ||
| get => _isLoading; | ||
| set | ||
| { | ||
| _isLoading = value; | ||
| OnPropertyChanged(nameof(IsLoading)); | ||
| } | ||
| } | ||
|
|
||
| public ICommand RefreshCommand { get; set; } | ||
| public Issue31375() | ||
| { | ||
| // Create UI elements | ||
| var button = new Button { Text = "Click To Refresh", AutomationId = "RefreshButton" }; | ||
| button.Clicked += Button_Clicked; | ||
|
|
||
| _textLabel = new Label() { AutomationId = "CounterLabel" }; | ||
| _textLabel.Text = count++.ToString(); | ||
|
|
||
| // Set BindingContext | ||
| BindingContext = this; | ||
|
|
||
| // Assign command | ||
| RefreshCommand = new Command(AddItems); | ||
| var refreshView = new RefreshView | ||
| { | ||
| Margin = 16, | ||
| Content = _textLabel, | ||
| }; | ||
| refreshView.SetBinding(RefreshView.IsRefreshingProperty, nameof(IsLoading)); | ||
| refreshView.SetBinding(RefreshView.CommandProperty, nameof(RefreshCommand)); | ||
| Content = new StackLayout | ||
| { | ||
| Children = { refreshView, button } | ||
| }; | ||
| } | ||
|
|
||
| void Button_Clicked(object sender, EventArgs e) | ||
| { | ||
| IsLoading = true; | ||
| } | ||
|
|
||
| void AddItems() | ||
| { | ||
| IsLoading = false; | ||
| _textLabel.Text = count++.ToString(); | ||
| } | ||
| } |
24 changes: 24 additions & 0 deletions
24
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31375.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues | ||
| { | ||
| public class Issue31375 : _IssuesUITest | ||
| { | ||
| public Issue31375(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "[Windows] RefreshView Command executes multiple times when IsRefreshing is set to True"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.RefreshView)] | ||
| public void VerifyRefreshViewCommandExecution() | ||
| { | ||
| App.WaitForElement("CounterLabel"); | ||
| App.Tap("RefreshButton"); | ||
| Assert.That(App.FindElement("CounterLabel").GetText(), Is.EqualTo("1")); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.