-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Fix RefreshView Command executes multiple times when IsRefreshing is set to True #31471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fix RefreshView Command executes multiple times when IsRefreshing is set to True #31471
Conversation
|
Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…eshing is set to True (#31471) * fix added * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * test case added * Update RefreshViewHandler.Windows.cs * Update Issue31375.cs * Update Issue31375.cs
…eshing is set to True (#31471) * fix added * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * test case added * Update RefreshViewHandler.Windows.cs * Update Issue31375.cs * Update Issue31375.cs
…eshing is set to True (#31471) * fix added * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * test case added * Update RefreshViewHandler.Windows.cs * Update Issue31375.cs * Update Issue31375.cs
…eshing is set to True (#31471) * fix added * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * test case added * Update RefreshViewHandler.Windows.cs * Update Issue31375.cs * Update Issue31375.cs
…eshing is set to True (#31471) * fix added * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * test case added * Update RefreshViewHandler.Windows.cs * Update Issue31375.cs * Update Issue31375.cs
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause
On Windows, setting IsRefreshing = true programmatically triggered RequestRefresh(), which fired the refresh event again and caused an infinite loop.
Description of Change
In the Refresh event, the IsRefreshing property should be set to true only when its current value is false. This prevents unnecessary refresh cycles and avoids triggering the refresh logic repeatedly when it is already in progress.
Issues Fixed
Fixes #31375
Validated the behaviour in the following platforms
Output Screenshot
Before.mp4
After.mp4