[Windows] Fixed CollectionView throws NRE when value of IsGrouped property is changed to false #27331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikraja-arumugam
added
the
partner/syncfusion
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue17864.xaml: Language not supported
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17864.cs:22
- Add a check to ensure that the CollectionView is correctly updated after the IsGrouped property changes.
App.WaitForElement(CollectionView);
| public void CollectionViewShouldNotCrashWhenIsGroupedChanges() | ||
| { | ||
| App.WaitForElement(CollectionView); | ||
| App.Tap("Button"); |
There was a problem hiding this comment.
Ensure that the AutomationId for 'Button' is unique and not reused, or WaitForElement will fail to find the correct element.
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-17864
branch
from
fa90e42 to
64f07b9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-17864
branch
from
64f07b9 to
8ee52ca
Compare
|
/rebase |
github-actions
bot
force-pushed
the
fix-17864
branch
from
8ee52ca to
5560feb
Compare
jfversluis
added
the
area-controls-collectionview
|
/rebase |
github-actions
bot
force-pushed
the
fix-17864
branch
from
5560feb to
7dc3dea
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
NullReference exception is thrown when disabling IsGrouped at runtime.
Root Cause
The value passed as the itemsource when creating a groupItemsList is not IEnumerable. This causes the value to be set as null.
Description of Change
Ensured the value is of type IEnumerable and pass it to Create method of TemplatedItemSourceFactory to avoid null reference exceptions.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #17864
Fixes #28824
Output
Before.mp4
After.mp4