Skip to content

[testing] Ignore flacky tests on iOS17 #20581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2024
Merged

[testing] Ignore flacky tests on iOS17 #20581

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce66b60
[tests] Ignore more keyboard tests
rmarinho Feb 14, 2024
8e9f804
[tests] Ignore Issue18751Test as image comparison fails
rmarinho Feb 14, 2024
6368897
Use Ignore attribute
rmarinho Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Controls/tests/UITests/Tests/Issues/Issue17022.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,13 @@ public void Issue17022Test(string testButtonID, bool isTopOfScreen, bool require
else
{
if (isTopOfScreen)
{
Assert.AreEqual(rect.Y, 0);
}
else
{
Assert.AreNotEqual(rect.Y, 0);
}
}
}
catch
Expand Down
22 changes: 11 additions & 11 deletions src/Controls/tests/UITests/Tests/Issues/Issue18751.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@ public Issue18751(TestDevice device) : base(device)

public override string Issue => "Can scroll CollectionView inside RefreshView";

[Test]
public async Task Issue18751Test()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Windows },
"Currently fails on Windows; see https://github.com/dotnet/maui/issues/15994");
// [Test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the Skip attribute with the link to the issue to re-enable them #20582?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

// public async Task Issue18751Test()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Windows },
// "Currently fails on Windows; see https://github.com/dotnet/maui/issues/15994");

App.WaitForElement("WaitForStubControl");
// App.WaitForElement("WaitForStubControl");

// Load images.
await Task.Delay(1000);
// // Load images.
// await Task.Delay(1000);

// The test passes if you are able to see the image, name, and location of each monkey.
VerifyScreenshot();
}
// // The test passes if you are able to see the image, name, and location of each monkey.
// VerifyScreenshot();
// }
}
}
36 changes: 18 additions & 18 deletions src/Controls/tests/UITests/Tests/KeyboardScrollingNonScrollingPageSmallTitlesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,25 @@ protected override void FixtureTeardown()
this.Back();
}

[Test]
public void EntriesScrollingPageTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EntriesScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EntriesScrollingPageTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EntriesScrollingTest(App, KeyboardScrollingGallery);
// }

[Test]
public void EditorsScrollingPageTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EditorsScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EditorsScrollingPageTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EditorsScrollingTest(App, KeyboardScrollingGallery);
// }

[Test]
public void EntryNextEditorTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EntryNextEditorScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EntryNextEditorTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EntryNextEditorScrollingTest(App, KeyboardScrollingGallery);
// }
}
}
36 changes: 18 additions & 18 deletions src/Controls/tests/UITests/Tests/KeyboardScrollingScrollingPageLargeTitlesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,25 @@ protected override void FixtureTeardown()
this.Back();
}

[Test]
public void EntriesScrollingPageTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EntriesScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EntriesScrollingPageTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EntriesScrollingTest(App, KeyboardScrollingGallery);
// }

[Test]
public void EditorsScrollingPageTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EditorsScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EditorsScrollingPageTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EditorsScrollingTest(App, KeyboardScrollingGallery);
// }

[Test]
public void EntryNextEditorTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EntryNextEditorScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EntryNextEditorTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EntryNextEditorScrollingTest(App, KeyboardScrollingGallery);
// }
}
}
36 changes: 18 additions & 18 deletions src/Controls/tests/UITests/Tests/KeyboardScrollingScrollingPageSmallTitlesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,25 @@ protected override void FixtureTeardown()
this.Back();
}

[Test]
public void EntriesScrollingPageTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EntriesScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EntriesScrollingPageTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EntriesScrollingTest(App, KeyboardScrollingGallery);
// }

[Test]
public void EditorsScrollingPageTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EditorsScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EditorsScrollingPageTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EditorsScrollingTest(App, KeyboardScrollingGallery);
// }

[Test]
public void EntryNextEditorTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
KeyboardScrolling.EntryNextEditorScrollingTest(App, KeyboardScrollingGallery);
}
// [Test]
// public void EntryNextEditorTest()
// {
// this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows }, KeyboardScrolling.IgnoreMessage);
// KeyboardScrolling.EntryNextEditorScrollingTest(App, KeyboardScrollingGallery);
// }
}
}