Skip to content

[testing] Ignore flacky tests on iOS17 #20581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2024
Merged

[testing] Ignore flacky tests on iOS17 #20581

merged 3 commits into from
Feb 14, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Feb 14, 2024

Description of Change

These tests seem to fail on iOS17, we are going to disable for now and look at them better and renable.

{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Windows },
"Currently fails on Windows; see https://github.com/dotnet/maui/issues/15994");
// [Test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the Skip attribute with the link to the issue to re-enable them #20582?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@rmarinho rmarinho merged commit 63bffb3 into main Feb 14, 2024
@rmarinho rmarinho deleted the ignore-tests branch February 14, 2024 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants