Enable MTP tests via MSBuild property #9361
Conversation
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
Enables Microsoft Testing Platform (MTP) tests by adjusting the MSBuild property and cleaning up an outdated workaround.
- Set
<DisableTestingPlatformServerCapability>tofalseto allow MTP tests to run. - Remove legacy workaround comments for VS Code/Test Explorer.
| <!-- Workaround for VSCode issues, until it's figured out and resolved. --> | ||
| <!-- This basically causes Test Explorer in VS and VS Code to use VSTest --> | ||
| <DisableTestingPlatformServerCapability>true</DisableTestingPlatformServerCapability> | ||
| <DisableTestingPlatformServerCapability>false</DisableTestingPlatformServerCapability> |
There was a problem hiding this comment.
This is the default already and can be removed safely
There was a problem hiding this comment.
I was leaning towards leaving it in case we need to go back and disable this again. I like Copilot's recommendation of adding a comment as extra clarity.
|
Let's run an Azdo build for this too. |
|
Azdo validation run - https://dev.azure.com/dnceng-public/public/_build/results?buildId=1043833&view=results |
|
How does this affect test runs? Does it work on VS too? |
|
This PR shouldn't affect command line scenarios (including CI). It only impacts IDE (both VS and DevKit) |
@Youssef1313 can share more about how it affects test runs since he has more insight onto the implementation. It does work in VS. We originally disabled it because it was broken in VS Code. Verified this works locally on macOS. |
Link discussion of issues around `dotnet test` and MTP found at dotnet/sdk#45927 and dotnet/sdk#49210 For more related discussions, see: + dotnet/aspire#9361 + dotnet/aspire#8833
I've verified that the run-debug-test loop works or me in Codespaces with this change and the one from #9261.
cc: @peterwald @Youssef1313
cc: @radical I noticed there were some reverts/re-reverts on the PR mentioned above but I think everything is back to the state introduced by the commit from the PR.