Skip to content

Update xUnit.v3 to support MTP tests #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2025
Merged

Update xUnit.v3 to support MTP tests #9261

merged 4 commits into from
May 15, 2025
+5 −5

Conversation

@peterwald
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 12, 2025
@peterwald peterwald requested a review from captainsafia May 12, 2025 19:38
@RussKie RussKie requested review from Youssef1313 and removed request for captainsafia May 12, 2025 23:08
@RussKie RussKie added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels May 12, 2025
@RussKie
Copy link
Contributor

RussKie commented May 12, 2025

@Youssef1313 may you please have a look?

@danmoseley
Copy link
Member

What does this do for us?

@danmoseley
Copy link
Member

kicked off mirror of xunit.v3,xunit.v3.core,xunit.v3.assert,xunit.runner.visualstudio

@danmoseley danmoseley closed this May 13, 2025
@danmoseley danmoseley reopened this May 13, 2025
@peterwald
Copy link
Member Author

What does this do for us?

MTP is the latest testing sdk. Aspire had previously migrated to it, but rolled back due to lack of source information in xUnit.v3. The bug has been fixed in xUnit, so we can roll forward to MTP once again.

@danmoseley
Copy link
Member

OK. Could someone konwledgeable like @Youssef1313 review?

@danmoseley
Copy link
Member

We branched for 9.3 so ready to merge this if we can get a review

@captainsafia
Copy link
Member

I was planning on sanity checking the run-debug-test flow with this PR but I'm running into new and unrelated issues with debugging in VS Code so I can't validate ATM.

We can probably sanity check this in Codespaces though 🤔

captainsafia
captainsafia approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified run-debug-test on Codespaces!

@peterwald peterwald merged commit 0c5232d into dotnet:main May 15, 2025
254 checks passed
radical added a commit to radical/aspire that referenced this pull request May 15, 2025
@radical
Revert "Update xUnit.v3 to support MTP tests (dotnet#9261)"
a1126d8 
This reverts commit 0c5232d.

This broke the azdo builds with:
```
  You must install or update .NET to run this application.

  App: /mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests
  Architecture: x64
  Framework: 'Microsoft.NETCore.App', version '8.0.0' (x64)
  .NET location: /usr/lib/dotnet

  The following frameworks were found:
    6.0.36 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App]

  Learn about framework resolution:
  https://aka.ms/dotnet/app-launch-failed

  To install missing framework, download:
  https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=ubuntu.22.04-x64
/mnt/vss/_work/1/s/tests/Directory.Build.targets(39,5): error MSB3073: The command ""/mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests" --filter-not-trait category=failing --list-tests" exited with code 150. [/mnt/vss/_work/1/s/tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj]
 ##[error]tests/Directory.Build.targets(39,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests" --filter-not-trait category=failing --list-tests" exited with code 150.
```
danmoseley pushed a commit that referenced this pull request May 15, 2025
@radical
Revert "Update xUnit.v3 to support MTP tests (#9261)" (#9336)
3850afa 
This reverts commit 0c5232d.

This broke the azdo builds with:
```
  You must install or update .NET to run this application.

  App: /mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests
  Architecture: x64
  Framework: 'Microsoft.NETCore.App', version '8.0.0' (x64)
  .NET location: /usr/lib/dotnet

  The following frameworks were found:
    6.0.36 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App]

  Learn about framework resolution:
  https://aka.ms/dotnet/app-launch-failed

  To install missing framework, download:
  https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=ubuntu.22.04-x64
/mnt/vss/_work/1/s/tests/Directory.Build.targets(39,5): error MSB3073: The command ""/mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests" --filter-not-trait category=failing --list-tests" exited with code 150. [/mnt/vss/_work/1/s/tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj]
 ##[error]tests/Directory.Build.targets(39,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests" --filter-not-trait category=failing --list-tests" exited with code 150.
```
radical added a commit to radical/aspire that referenced this pull request May 15, 2025
@radical
Revert "Revert "Update xUnit.v3 to support MTP tests (dotnet#9261)" (d…
47c5710 
…otnet#9336)"

The earlier revert was incorrect. That wasn't commit responsible for
breaking the build. It was:
```
commit 6ca2de9
Author: Ankit Jain <[email protected]>
Date:   Wed May 14 11:39:18 2025 -0400

    [CI] Add PR validation on macOS (dotnet#9287)
```

This reverts commit 3850afa.
danmoseley pushed a commit that referenced this pull request May 15, 2025
@radical
Revert "Revert "Update xUnit.v3 to support MTP tests (#9261)" (#9336)" (
c8beecd 
#9337)

The earlier revert was incorrect. That wasn't commit responsible for
breaking the build. It was:
```
commit 6ca2de9
Author: Ankit Jain <[email protected]>
Date:   Wed May 14 11:39:18 2025 -0400

    [CI] Add PR validation on macOS (#9287)
```

This reverts commit 3850afa.
@RussKie RussKie mentioned this pull request May 16, 2025
Merged
@Youssef1313
Copy link
Member

@peterwald @RussKie @captainsafia @danmoseley This change is unlikely to have any effect.

The following needs to be removed as well:

aspire/tests/Shared/RepoTesting/Aspire.RepoTesting.props

Lines 22 to 24 in 8929f2f

<!-- Workaround for VSCode issues, until it's figured out and resolved. -->
<!-- This basically causes Test Explorer in VS and VS Code to use VSTest -->
<DisableTestingPlatformServerCapability>true</DisableTestingPlatformServerCapability>

Then it will require additional validation from at least @captainsafia that it works in VS Code in macOS and/or Codespaces.

@captainsafia
Copy link
Member

@Youssef1313 Darn -- I'll open a PR with the change. Fingers crossed we still see a working run-debug-test loop.

@captainsafia captainsafia mentioned this pull request May 16, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@captainsafia captainsafia captainsafia approved these changes

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

Assignees

No one assigned

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterwald @RussKie @danmoseley @captainsafia @Youssef1313