Skip to content

Fix feed for daily builds from main branch #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix feed for daily builds from main branch #6472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8625e5
Fix feed for daily builds from main branch
joperezr Oct 24, 2024
469e815
Update using-latest-daily.md
joperezr Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/using-latest-daily.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ If you use [Package Source Mapping](https://learn.microsoft.com/en-us/nuget/cons
<packageSource key="dotnet9">
<package pattern="Aspire.*" />
<package pattern="Microsoft.Extensions.ServiceDiscovery*" />
<package pattern="Microsoft.Extensions.Http.Resilience" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure all the uses of this package in the repo are using a version that's from the dotnet9 feed? If some are using 8.0.10 still we'll need to include nuget.org and have a mapping for that too I think.

Copy link
Member

@DamianEdwards DamianEdwards Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In updating dotnet/aspire-samples to use dailies I'm finding I need a mapping for Microsoft.Extensions.Resilience too. Maybe we just make this Microsoft.Extensions.*?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0.10 is out on nuget.org. Perhaps we should instead not try to guess and remove the package source mapping from our suggested nuget.config, as the actual one that the users end up using will be different depending on the things that their app is using.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way our instructions are now, we are only providing the mappings for the packages produced in this repo, but that is not a guarantee that you won't need more depending on your project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make it as clear as possible to help folks set their project up for the highest changes of success.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we need all feeds that the Aspire bits need. That includes non-released dependencies we're building against. Or are there none of those now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the blocker with this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is just to make sure that the feeds are complete, but I just haven't had the chance to come back to this as it's been a bit hectic the last few days. If we want to merge as is, we could and I can send a follow-up later to address feedback, or otherwise I can take a look at this in a few days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea lets its broken right now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, merging.

</packageSource>
</packageSourceMapping>
```
Expand Down