Skip to content

Update to Aspire 9.1 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Feb 26, 2025
Merged

Update to Aspire 9.1 #521

merged 28 commits into from
Feb 26, 2025

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Oct 24, 2024 •
edited
Loading

Update to Aspire 9.1 and all deps to latest versions.

@DamianEdwards DamianEdwards mentioned this pull request Oct 24, 2024
Merged
@DamianEdwards DamianEdwards mentioned this pull request Jan 23, 2025
Closed
1 task
@DamianEdwards DamianEdwards marked this pull request as ready for review February 25, 2025 01:40
@Copilot Copilot AI review requested due to automatic review settings February 25, 2025 01:40
Copilot
Copilot AI reviewed Feb 25, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 89 out of 89 changed files in this pull request and generated no comments.

eerhardt
eerhardt reviewed Feb 25, 2025
View reviewed changes
@DamianEdwards DamianEdwards changed the title [WIP] Update to Aspire 9.1 Update to Aspire 9.1 Feb 25, 2025
eerhardt
eerhardt reviewed Feb 25, 2025
View reviewed changes
tests/SamplesIntegrationTests/SamplesIntegrationTests.csproj
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this downgrade?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we haven't moved to xunit 3 yet. Do the xunit templates in the .NET SDK use v3 of this package yet?

@DamianEdwards DamianEdwards mentioned this pull request Feb 25, 2025
Open
DamianEdwards and others added 4 commits February 25, 2025 12:10
@DamianEdwards
PR feedback
e3217f8
@DamianEdwards
Update dependabot.yml
71173af
@DamianEdwards
Update HealthChecksUI.ServiceDefaults.csproj
a038e5d
@eerhardt
PR feedback
ff968f6 
- Remove gRPC instrumentation where gRPC isn't being used
- Ensure all OTel references are 1.9.0
- Use AspNetCore.HealthChecks v9 everywhere
eerhardt
eerhardt approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed some minor feedback changes I had. I think this is ready to merge.

@DamianEdwards DamianEdwards merged commit 9a0955b into main Feb 26, 2025
3 checks passed
@DamianEdwards DamianEdwards deleted the UpdateToAspire9.1 branch February 26, 2025 19:20
@danmoseley danmoseley mentioned this pull request Mar 6, 2025
Merged
@gewarren gewarren mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamianEdwards @eerhardt