Allow referencing older version of AppHost package for backward compatibility #5556
Conversation
joperezr
requested review from
radical,
eerhardt,
mitchdenny and
ReubenBond
as code owners
ghost
added
the
area-integrations
|
do ittttt. there's no way this is going to break CI systems again, right? 😄 |
Well now you've jinxed it 🤭....jk. The plan is that this change would undo the regression, and allow people to remove the manual workarounds they had to do to pin an older version of the workload. |
|
This is a temporary solution until 9.0, right? iiuc 9.0 will no longer require installing the workload, as the only thing it will do is keep the templates up-to-date. Is that the right understanding? |
|
@KennethHoff correct |
davidfowl
added
area-tooling
and removed
area-integrations
|
Wouldn't this need to go only into the 8.2 branch instead of main? |
|
The plan is to backport to 8.2 once this is merged. We still have to do workload authoring changes for 9 which will modify this code again in main branch, so for now we should have it in both places. |
|
@DamianEdwards @eerhardt @radical any feedback here? Would be good to get this one closed so we can open the backport PR |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| } | ||
|
|
||
| [Fact] | ||
| public async Task EnsureProjectsReferencing8_1_0WorkloadCanBuild() |
There was a problem hiding this comment.
Should this be named EnsureProjectsReferencing8_1_0AppHostWithNewerWorkloadCanBuild?
Conceptually good from my side. |
| </PropertyGroup> | ||
|
|
||
| <!-- At this point, we should have the version either by CPM or PackageReference, so we fail if not. --> | ||
| <Error Condition="'$(_AppHostVersion)' == '' or $([MSBuild]::VersionLessThan('$(_AppHostVersion)', '8.2.0'))" | ||
| Text="$(MSBuildProjectName) is a .NET Aspire AppHost project that needs a package reference to Aspire.Hosting.AppHost version 8.2.0 or above to work correctly.$(__CurrentAppHostVersionMessage)" /> | ||
| <Error Condition="'$(_AppHostVersion)' == ''" |
There was a problem hiding this comment.
A test for this would be good too. It doesn't have to be in this PR.
Also, the same for both cases but with CPM?
There was a problem hiding this comment.
I'll add more tests to this whole scenario with the changes on the Aspire Workload for 9.0
|
/backport to release/8.2 |
|
Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10853030465 |
Description
This would walk back on a decision we took in 8.2.0 where we forced people to reference the 8.2.0 AppHost package when moving to the new workload, and instead allow for backward compatibility preserving the old behavior where, if that is the case, then the version of dashboard and DCP people would get would match the version of the workload they have installed.
The intention would be to backport this to release/8.2 branch so it can be serviced in 8.2.1
cc: @DamianEdwards @davidfowl @eerhardt @maddymontaquila @radical
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow