Skip to content

Commit 2078fc6

Browse files
eerhardtradical
authored andcommitted
Remove ASPIREHOSTINGPYTHON001 (#12420)
The Python APIs should be considered stable for this release. Fix #12163
1 parent 054356b commit 2078fc6

File tree

9 files changed

+6
-32
lines changed

9 files changed

+6
-32
lines changed

playground/AspireWithPython/AspireWithPython.AppHost/AppHost.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
#pragma warning disable ASPIREHOSTINGPYTHON001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
2-
3-
using Microsoft.Extensions.Hosting;
1+
using Microsoft.Extensions.Hosting;
42

53
var builder = DistributedApplication.CreateBuilder(args);
64

playground/python/Python.AppHost/Program.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

4-
#pragma warning disable ASPIREHOSTINGPYTHON001 // Test for experimental feature
5-
64
var builder = DistributedApplication.CreateBuilder(args);
75

86
builder.AddPythonScript("script-only", "../script_only", "main.py");

src/Aspire.Hosting.Python/AssemblyInfo.cs

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/Aspire.Hosting.Python/PythonAppResourceBuilderExtensions.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@
1010
using Microsoft.Extensions.DependencyInjection;
1111
using Microsoft.Extensions.Logging;
1212

13+
#pragma warning disable ASPIREDOCKERFILEBUILDER001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
1314
#pragma warning disable ASPIREEXTENSION001
15+
#pragma warning disable ASPIREPIPELINES001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
16+
#pragma warning disable ASPIREPUBLISHERS001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
1417

1518
namespace Aspire.Hosting;
1619

src/Aspire.ProjectTemplates/templates/aspire-py-starter/13.0/apphost.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
#:package Aspire.Hosting.Redis@!!REPLACE_WITH_LATEST_VERSION!!
66
#endif
77

8-
#pragma warning disable ASPIREHOSTINGPYTHON001
9-
108
var builder = DistributedApplication.CreateBuilder(args);
119

1210
#if UseRedisCache

tests/Aspire.Hosting.Docker.Tests/Aspire.Hosting.Docker.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
<PropertyGroup>
44
<TargetFramework>$(DefaultTargetFramework)</TargetFramework>
5-
<NoWarn>$(NoWarn);ASPIREHOSTINGPYTHON001;</NoWarn>
65

76
<!--
87
Do not run tests in Helix at all

tests/Aspire.Hosting.Kubernetes.Tests/Aspire.Hosting.Kubernetes.Tests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22

33
<PropertyGroup>
44
<TargetFramework>$(DefaultTargetFramework)</TargetFramework>
5-
<NoWarn>
6-
$(NoWarn);
7-
ASPIREHOSTINGPYTHON001;
8-
</NoWarn>
95
</PropertyGroup>
106

117
<ItemGroup>

tests/Aspire.Hosting.Python.Tests/Aspire.Hosting.Python.Tests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22

33
<PropertyGroup>
44
<TargetFramework>$(DefaultTargetFramework)</TargetFramework>
5-
<NoWarn>
6-
$(NoWarn);
7-
ASPIREHOSTINGPYTHON001;
8-
</NoWarn>
95
</PropertyGroup>
106

117
<ItemGroup>

tests/Aspire.Hosting.Tests/WithReferenceTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -549,10 +549,10 @@ public async Task PythonAppResourceWithReferenceGetsConnectionStringAndPropertie
549549
ConnectionString = "Server=localhost;Database=mydb"
550550
});
551551

552-
#pragma warning disable ASPIREHOSTINGPYTHON001, CS0612, CS0618, CS0619 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
552+
#pragma warning disable CS0618
553553
var executable = builder.AddPythonApp("PythonApp", ".\\app", "app.py")
554554
.WithReference(resource);
555-
#pragma warning restore ASPIREHOSTINGPYTHON001, CS0612, CS0618, CS0619 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
555+
#pragma warning restore CS0618
556556

557557
// Call environment variable callbacks.
558558
var config = await EnvironmentVariableEvaluator.GetEnvironmentVariablesAsync(executable.Resource, DistributedApplicationOperation.Run, TestServiceProvider.Instance).DefaultTimeout();

0 commit comments

Comments
 (0)